Sanitize escape char in Transformer::transformSymbolicName #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav8297
force-pushed
the
fix_escape_char
branch
from
dcb0bdd
to
0893c32
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1645 +/- ##
==========================================
- Coverage 91.49% 91.48% -0.01%
==========================================
Files 725 725
Lines 26326 26327 +1
==========================================
Hits 24086 24086
- Misses 2240 2241 +1
☔ View full report in Codecov by Sentry. |
andyfengHKU
approved these changes
Jun 7, 2023
Escaped symbol name from parser will be of form "`Some.Value`". Therefore, we need to sanitize it such that we don't store the symbol with escape character.
gaurav8297
force-pushed
the
fix_escape_char
branch
from
0893c32
to
eeaef34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escaped symbol name coming from the parser is of form "`Some.Value`". Therefore, we need to sanitize it such that we don't store the symbol with escape characters.