Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework column write function #1540

Merged
merged 1 commit into from
May 15, 2023
Merged

Rework column write function #1540

merged 1 commit into from
May 15, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented May 15, 2023

No description provided.

@ray6080 ray6080 requested a review from acquamarin May 15, 2023 16:36
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.13 🎉

Comparison is base (e9e27a1) 91.85% compared to head (efbc9a6) 91.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1540      +/-   ##
==========================================
+ Coverage   91.85%   91.98%   +0.13%     
==========================================
  Files         689      689              
  Lines       24668    24623      -45     
==========================================
- Hits        22658    22649       -9     
+ Misses       2010     1974      -36     
Impacted Files Coverage Δ
...rc/storage/storage_structure/storage_structure.cpp 98.75% <ø> (+26.93%) ⬆️
src/storage/wal_replayer_utils.cpp 98.50% <0.00%> (ø)
src/storage/storage_structure/column.cpp 91.85% <81.08%> (+1.29%) ⬆️
src/include/storage/storage_structure/column.h 96.77% <100.00%> (-0.20%) ⬇️
...lude/storage/storage_structure/storage_structure.h 100.00% <100.00%> (ø)
src/processor/operator/update/set.cpp 100.00% <100.00%> (ø)
src/storage/store/rel_table.cpp 98.82% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ray6080 ray6080 merged commit ab47844 into master May 15, 2023
7 checks passed
@ray6080 ray6080 deleted the column-rework branch May 15, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants