Add SERIAL as node table primary key #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1493 +/- ##
==========================================
- Coverage 92.20% 92.18% -0.03%
==========================================
Files 671 671
Lines 24069 24123 +54
==========================================
+ Hits 22194 22238 +44
- Misses 1875 1885 +10
☔ View full report in Codecov by Sentry. |
andyfengHKU
approved these changes
Apr 27, 2023
| assert(structureIDAndFName.storageStructureID.columnFileID.columnType == | ||
| ColumnType::REL_PROPERTY_COLUMN); | ||
| StorageStructureType::COLUMN && | ||
| structureIDAndFName.storageStructureID.columnFileID.columnType == |
There was a problem hiding this comment.
This is not related to this PR but I really hate this structureIDAndFName.storageStructureID.storageStructureType naming and call chain.
I think we should just use s to stand for storageStructure. It's insane to see storageStructure everywhere as a naming prefix.
6 tasks
20 tasks
tnachen
reviewed
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
SERIALas a special data type for primary key properties, whose values are same as internal node offsets. This can speed up data ingestion, as no index construction/lookup is required during data ingestion.SERIALis limited to primary key of node tables only for now.This PR hasn't handled updates, index scan, and expression evaluations over
SERIAL. See #1496 .