Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect cast int16 func name #1484

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Fix incorrect cast int16 func name #1484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion src/common/arrow/arrow_row_batch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,6 @@ ArrowArray ArrowRowBatch::append(main::QueryResult& queryResult, std::int64_t ch
break;
}
auto tuple = queryResult.getNext();
std::vector<std::uint32_t> colWidths(numColumns, 10);
for (auto i = 0u; i < numColumns; i++) {
appendValue(vectors[i].get(), *typesInfo[i], tuple->getValue(i));
}
Expand Down
8 changes: 4 additions & 4 deletions src/function/vector_cast_operations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,13 +217,13 @@ CastToInt16VectorOperation::getDefinitions() {
std::vector<std::unique_ptr<VectorOperationDefinition>> result;
// down cast
result.push_back(bindVectorOperation<int32_t, int16_t, operation::CastToInt16>(
CAST_TO_INT32_FUNC_NAME, INT32, INT16));
CAST_TO_INT16_FUNC_NAME, INT32, INT16));
result.push_back(bindVectorOperation<int64_t, int16_t, operation::CastToInt16>(
CAST_TO_INT32_FUNC_NAME, INT64, INT16));
CAST_TO_INT16_FUNC_NAME, INT64, INT16));
result.push_back(bindVectorOperation<float_t, int16_t, operation::CastToInt16>(
CAST_TO_INT32_FUNC_NAME, FLOAT, INT16));
CAST_TO_INT16_FUNC_NAME, FLOAT, INT16));
result.push_back(bindVectorOperation<double_t, int16_t, operation::CastToInt16>(
CAST_TO_INT32_FUNC_NAME, DOUBLE, INT16));
CAST_TO_INT16_FUNC_NAME, DOUBLE, INT16));
return result;
}

Expand Down