Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect cast int16 func name #1484

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Fix incorrect cast int16 func name #1484

merged 1 commit into from
Apr 22, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Apr 22, 2023

This incorrect naming leads to weird behaviours.
An example on tinysnb:

match (p:person) return to_int16(p.age), to_int32(p.age), p.age;

will produce wrong result for to_int16(p.age).
@andyfengHKU or @acquamarin should take a further look.
I would propose to add a function validity check mechanism in catalog when we register any functions, so probably we can avoid this kind of mistakes later.

@ray6080 ray6080 merged commit 8dc87ca into master Apr 22, 2023
@ray6080 ray6080 deleted the fix-cast branch April 22, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants