Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spdlog/fmt from header #1451

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Remove spdlog/fmt from header #1451

merged 1 commit into from
Apr 6, 2023

Conversation

mewim
Copy link
Collaborator

@mewim mewim commented Apr 6, 2023

No description provided.

@mewim mewim force-pushed the pre-compile-fix branch 2 times, most recently from 94cf544 to a099ceb Compare April 6, 2023 17:19
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage: 88.46% and project coverage change: -0.01 ⚠️

Comparison is base (a2f042f) 92.67% compared to head (b92e499) 92.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1451      +/-   ##
==========================================
- Coverage   92.67%   92.67%   -0.01%     
==========================================
  Files         652      655       +3     
  Lines       22822    22817       -5     
==========================================
- Hits        21151    21146       -5     
  Misses       1671     1671              
Impacted Files Coverage Δ
src/binder/bind/bind_copy.cpp 86.90% <ø> (ø)
src/binder/bind/bind_ddl.cpp 100.00% <ø> (ø)
...inder/bind_expression/bind_function_expression.cpp 98.26% <ø> (ø)
src/binder/binder.cpp 96.26% <ø> (-0.04%) ⬇️
src/catalog/catalog.cpp 89.84% <ø> (ø)
src/catalog/catalog_structs.cpp 62.50% <ø> (ø)
src/common/assert.cpp 60.00% <ø> (ø)
src/common/file_utils.cpp 71.83% <ø> (ø)
src/common/logging_level_utils.cpp 71.42% <ø> (ø)
src/common/type_utils.cpp 61.70% <ø> (ø)
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mewim mewim merged commit ad464cc into master Apr 6, 2023
@mewim mewim deleted the pre-compile-fix branch April 6, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants