Remove spdlog/fmt from header

kuzudb · Apr 6, 2023 · 94cf544 · 94cf544
1 parent a2f042f
commit 94cf544
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/common/utils.cpp b/src/common/utils.cpp
@@ -1,5 +1,6 @@
 #include "common/utils.h"
 
+#include "spdlog/fmt/fmt.h"
 #include "spdlog/sinks/stdout_sinks.h"
 #include "spdlog/spdlog.h"
 
@@ -60,6 +61,11 @@ std::string LoggerUtils::getLoggerName(LoggerConstants::LoggerEnum loggerEnum) {
     }
 }
 
+template<typename... Args>
+std::string StringUtils::string_format(const std::string& format, Args... args) {
+    return fmt::format(fmt::runtime(format), args...);
+}
+
 std::vector<std::string> StringUtils::split(
     const std::string& input, const std::string& delimiter) {
     auto result = std::vector<std::string>();

diff --git a/src/include/common/utils.h b/src/include/common/utils.h
@@ -11,7 +11,6 @@
 
 #include "common/constants.h"
 #include "exception.h"
-#include "spdlog/fmt/fmt.h"
 
 namespace spdlog {
 class logger;
@@ -35,9 +34,7 @@ class StringUtils {
 
 public:
     template<typename... Args>
-    inline static std::string string_format(const std::string& format, Args... args) {
-        return fmt::format(fmt::runtime(format), args...);
-    }
+    static std::string string_format(const std::string& format, Args... args);
 
     static std::vector<std::string> split(const std::string& input, const std::string& delimiter);