Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerical downcast #1429

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Numerical downcast #1429

merged 1 commit into from
Mar 31, 2023

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 89.58% and project coverage change: +0.03 🎉

Comparison is base (728a28b) 92.65% compared to head (65b6c77) 92.68%.

❗ Current head 65b6c77 differs from pull request most recent head 31433c8. Consider uploading reports for the commit 31433c8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1429      +/-   ##
==========================================
+ Coverage   92.65%   92.68%   +0.03%     
==========================================
  Files         650      650              
  Lines       22549    22596      +47     
==========================================
+ Hits        20892    20943      +51     
+ Misses       1657     1653       -4     
Impacted Files Coverage Δ
src/include/common/types/types.h 100.00% <ø> (ø)
src/binder/bind/bind_ddl.cpp 96.46% <50.00%> (-2.68%) ⬇️
src/include/function/cast/vector_cast_operations.h 77.77% <50.00%> (-22.23%) ⬇️
src/function/vector_cast_operations.cpp 85.29% <85.71%> (+12.84%) ⬆️
src/include/function/cast/cast_operations.h 98.03% <97.22%> (+11.37%) ⬆️
src/binder/expression_binder.cpp 97.26% <100.00%> (ø)
src/common/types/types.cpp 83.06% <100.00%> (+0.37%) ⬆️
src/common/types/value.cpp 87.98% <100.00%> (ø)
src/function/built_in_vector_operations.cpp 95.83% <100.00%> (-1.72%) ⬇️
src/include/common/types/value.h 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/binder/bind/bind_ddl.cpp Show resolved Hide resolved
@andyfengHKU andyfengHKU merged commit 7116e2e into master Mar 31, 2023
@andyfengHKU andyfengHKU deleted the numerical-downcast branch March 31, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants