fix test coverage

kuzudb · Mar 30, 2023 · 65b6c77 · 65b6c77
1 parent 996b64e
commit 65b6c77
Show file tree

Hide file tree

Showing 5 changed files with 56 additions and 9 deletions.
diff --git a/src/common/types/value.cpp b/src/common/types/value.cpp
@@ -85,6 +85,10 @@ Value::Value(int64_t val_) : dataType{INT64}, isNull_{false} {
     val.int64Val = val_;
 }
 
+Value::Value(float_t val_) : dataType{FLOAT}, isNull_{false} {
+    val.floatVal = val_;
+}
+
 Value::Value(double val_) : dataType{DOUBLE}, isNull_{false} {
     val.doubleVal = val_;
 }
@@ -118,10 +122,6 @@ Value::Value(DataType dataType, std::vector<std::unique_ptr<Value>> vals)
     listVal = std::move(vals);
 }
 
-Value::Value(float_t val_) : dataType{FLOAT}, isNull_{false} {
-    val.floatVal = val_;
-}
-
 Value::Value(std::unique_ptr<NodeVal> val_) : dataType{NODE}, isNull_{false} {
     nodeVal = std::move(val_);
 }

diff --git a/src/function/vector_cast_operations.cpp b/src/function/vector_cast_operations.cpp
@@ -186,7 +186,7 @@ CastToFloatVectorOperation::getDefinitions() {
         CAST_TO_FLOAT_FUNC_NAME, INT64, FLOAT));
     // down cast
     result.push_back(bindVectorOperation<double_t, float_t, operation::CastToFloat>(
-        CAST_TO_FLOAT_FUNC_NAME, INT16, FLOAT));
+        CAST_TO_FLOAT_FUNC_NAME, DOUBLE, FLOAT));
     return result;
 }
 

diff --git a/src/include/common/types/value.h b/src/include/common/types/value.h
@@ -383,6 +383,15 @@ inline int64_t Value::getValue() const {
     return val.int64Val;
 }
 
+/**
+ * @return float value.
+ */
+KUZU_API template<>
+inline float Value::getValue() const {
+    assert(dataType.getTypeID() == FLOAT);
+    return val.floatVal;
+}
+
 /**
  * @return double value.
  */

diff --git a/test/runner/e2e_update_node_test.cpp b/test/runner/e2e_update_node_test.cpp
@@ -10,12 +10,12 @@ class TinySnbUpdateTest : public DBTest {
     }
 
     std::string getStringExceedsOverflow() {
-        std::string veryLongList = "[";
-        for (int i = 0; i < 599; ++i) {
+        std::string veryLongList = "'[";
+        for (int i = 0; i < 5990; ++i) {
             veryLongList += std::to_string(i);
             veryLongList += ",";
         }
-        veryLongList += "599]";
+        veryLongList += "599]'";
         return veryLongList;
     }
 };
@@ -37,7 +37,13 @@ TEST_F(TinySnbUpdateTest, SetNodeInt32PropTest) {
 TEST_F(TinySnbUpdateTest, SetNodeDoublePropTest) {
     conn->query("MATCH (a:person) WHERE a.ID=0 SET a.eyeSight=1.0");
     auto result = conn->query("MATCH (a:person) WHERE a.ID=0 RETURN a.eyeSight");
-    ASSERT_EQ(result->getNext()->getValue(0)->getValue<double>(), 1.0);
+    ASSERT_EQ(result->getNext()->getValue(0)->getValue<double_t>(), 1.0);
+}
+
+TEST_F(TinySnbUpdateTest, SetNodeFloatPropTest) {
+    conn->query("MATCH (a:person) WHERE a.ID=0 SET a.height=12");
+    auto result = conn->query("MATCH (a:person) WHERE a.ID=0 RETURN a.height");
+    ASSERT_EQ(result->getNext()->getValue(0)->getValue<float_t>(), 12);
 }
 
 TEST_F(TinySnbUpdateTest, SetNodeBoolPropTest) {
@@ -174,6 +180,13 @@ TEST_F(TinySnbUpdateTest, SetIndexNestedLoopJoinTest) {
     ASSERT_EQ(TestHelper::convertResultToString(*result), groundTruth);
 }
 
+TEST_F(TinySnbUpdateTest, SetRelInt16PropTest) {
+    conn->query("MATCH (a:person)-[e:studyAt]->(b:organisation) WHERE a.ID = 0 SET e.length=99");
+    auto result = conn->query("MATCH (a:person)-[e:studyAt]->(b:organisation) RETURN e.length");
+    auto groundTruth = std::vector<std::string>{"22", "55", "99"};
+    ASSERT_EQ(TestHelper::convertResultToString(*result), groundTruth);
+}
+
 // Create clause test
 
 TEST_F(TinySnbUpdateTest, InsertNodeWithBoolIntDoubleTest) {

diff --git a/test/test_files/tinysnb/function/cast.test b/test/test_files/tinysnb/function/cast.test
@@ -1,3 +1,28 @@
+-NAME CastFromINT16
+-QUERY MATCH (p:person)-[e:studyAt]->(o:organisation) WHERE p.ID=0 RETURN to_int32(e.length), to_int64(e.length), to_float(e.length), to_double(e.length)
+---- 1
+5|5|5.000000|5.000000
+
+-NAME CastFromINT32
+-QUERY MATCH (m:movies) WHERE m.name='Roma' RETURN to_int16(m.length), to_int64(m.length), to_float(m.length), to_double(m.length)
+---- 1
+298|298|298.000000|298.000000
+
+-NAME CastFromINT64
+-QUERY MATCH (p:person) WHERE p.ID=0 RETURN to_int16(p.gender), to_int32(p.gender), to_float(p.gender), to_double(p.gender)
+---- 1
+1|1|1.000000|1.000000
+
+-NAME CastFromFLOAT
+-QUERY MATCH (p:person) WHERE p.ID=0 RETURN to_int16(p.height), to_int32(p.height), to_int64(p.height), to_double(p.height)
+---- 1
+1|1|1|1.731000
+
+-NAME CastFromDOUBLE
+-QUERY MATCH (p:person) WHERE p.ID=0 RETURN to_int16(p.eyeSight), to_int32(p.eyeSight), to_int64(p.eyeSight), to_float(p.eyeSight)
+---- 1
+5|5|5|5.000000
+
 -NAME CastBoolToString
 -QUERY MATCH (p:person) RETURN string(p.isStudent)
 ---- 8