Add limit to TENSOR size #1427
Merged
Add limit to TENSOR size #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
requested changes
Mar 30, 2023
src/storage/copier/table_copier.cpp
Outdated
| @@ -301,6 +301,14 @@ std::unique_ptr<uint8_t[]> TableCopier::getArrowFixedList(const std::string& l, | |||
| "Each fixed list should have fixed number of elements. Expected: {}, Actual: {}.", | |||
| dataType.fixedNumElementsInList, numElementsRead)); | |||
| } | |||
| if (numElementsRead * Types::getDataTypeSize(childDataType) >= | |||
There was a problem hiding this comment.
This is probably not the right place for this check.
For variable length data types, we perform this check when setting overflow to overflow_file.
For fixed length data types, this should be done at DDL level.
acquamarin
force-pushed
the
limit-fixed-list-size
branch
from
6830be5
to
ce6e40d
Compare
andyfengHKU
approved these changes
Mar 31, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1427 +/- ##
=======================================
Coverage 92.64% 92.65%
=======================================
Files 650 650
Lines 22544 22546 +2
=======================================
+ Hits 20886 20890 +4
+ Misses 1658 1656 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #1422