Skip to content

Commit

Permalink
Add limit to TENSOR size
Browse files Browse the repository at this point in the history
  • Loading branch information
acquamarin committed Mar 30, 2023
1 parent 6675cf1 commit 6830be5
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 0 deletions.
1 change: 1 addition & 0 deletions dataset/copy-fault-tests/large-fixed-list/schema.cypher
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
create node table person (ID INT64, hours INT64[512], PRIMARY KEY (ID));
1 change: 1 addition & 0 deletions dataset/copy-fault-tests/large-fixed-list/vPerson.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
0,"[0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,98,99,100,101,102,103,104,105,106,107,108,109,110,111,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128,129,130,131,132,133,134,135,136,137,138,139,140,141,142,143,144,145,146,147,148,149,150,151,152,153,154,155,156,157,158,159,160,161,162,163,164,165,166,167,168,169,170,171,172,173,174,175,176,177,178,179,180,181,182,183,184,185,186,187,188,189,190,191,192,193,194,195,196,197,198,199,200,201,202,203,204,205,206,207,208,209,210,211,212,213,214,215,216,217,218,219,220,221,222,223,224,225,226,227,228,229,230,231,232,233,234,235,236,237,238,239,240,241,242,243,244,245,246,247,248,249,250,251,252,253,254,255,256,257,258,259,260,261,262,263,264,265,266,267,268,269,270,271,272,273,274,275,276,277,278,279,280,281,282,283,284,285,286,287,288,289,290,291,292,293,294,295,296,297,298,299,300,301,302,303,304,305,306,307,308,309,310,311,312,313,314,315,316,317,318,319,320,321,322,323,324,325,326,327,328,329,330,331,332,333,334,335,336,337,338,339,340,341,342,343,344,345,346,347,348,349,350,351,352,353,354,355,356,357,358,359,360,361,362,363,364,365,366,367,368,369,370,371,372,373,374,375,376,377,378,379,380,381,382,383,384,385,386,387,388,389,390,391,392,393,394,395,396,397,398,399,400,401,402,403,404,405,406,407,408,409,410,411,412,413,414,415,416,417,418,419,420,421,422,423,424,425,426,427,428,429,430,431,432,433,434,435,436,437,438,439,440,441,442,443,444,445,446,447,448,449,450,451,452,453,454,455,456,457,458,459,460,461,462,463,464,465,466,467,468,469,470,471,472,473,474,475,476,477,478,479,480,481,482,483,484,485,486,487,488,489,490,491,492,493,494,495,496,497,498,499,500,501,502,503,504,505,506,507,508,509,510,511]"
8 changes: 8 additions & 0 deletions src/storage/copier/table_copier.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,14 @@ std::unique_ptr<uint8_t[]> TableCopier::getArrowFixedList(const std::string& l,
"Each fixed list should have fixed number of elements. Expected: {}, Actual: {}.",
dataType.fixedNumElementsInList, numElementsRead));
}
if (numElementsRead * Types::getDataTypeSize(childDataType) >=
BufferPoolConstants::PAGE_4KB_SIZE) {
throw ReaderException(StringUtils::string_format(
"Maximum number bytes of a FIXED_LIST is {}. Input list's num bytes is {}.",
BufferPoolConstants::PAGE_4KB_SIZE -
1 /* We need to reserve one byte for each page to store NULL byte */,
numElementsRead * Types::getDataTypeSize(childDataType.typeID)));
}
return listVal;
}

Expand Down
14 changes: 14 additions & 0 deletions test/copy/copy_fault_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ class CopyNullPKTest : public CopyFaultTest {
}
};

class CopyLargeFixedListTest : public CopyFaultTest {
std::string getInputDir() override {
return TestHelper::appendKuzuRootPath("dataset/copy-fault-tests/large-fixed-list/");
}
};

TEST_F(CopyDuplicateIDTest, DuplicateIDsError) {
validateCopyException(
"COPY person FROM \"" +
Expand Down Expand Up @@ -167,3 +173,11 @@ TEST_F(CopyNullPKTest, NullPKErrpr) {
TestHelper::appendKuzuRootPath("dataset/copy-fault-tests/null-pk/vPerson.csv\""),
"Reader exception: Primary key cannot be null.");
}

TEST_F(CopyLargeFixedListTest, LargeFixedListError) {
validateCopyException(
"COPY person FROM \"" + TestHelper::appendKuzuRootPath(
"dataset/copy-fault-tests/large-fixed-list/vPerson.csv\""),
"Reader exception: Maximum number bytes of a FIXED_LIST is 4095. Input list's num bytes is "
"4096.");
}

0 comments on commit 6830be5

Please sign in to comment.