Remove csv reader #1341
Merged
Remove csv reader #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
I think the copy test was meant to test CSVReader class but I might be wrong. Since we are removing CSVReader, can u open an issue and assign to @ray6080 to go back and see if we can remove this test.
In the issue also mention we should either rename cdv_reader.h and cpp or move the CSVReaderConfig somewhere else and delete the file.
mewim
force-pushed
the
remove-csv-reader
branch
2 times, most recently
from
3d1d7a8
to
2b0c543
Compare
Closed
|
I did not close #1338 and added a note in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1338