Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CSV reader #1338

Closed
andyfengHKU opened this issue Mar 2, 2023 · 1 comment
Closed

Remove CSV reader #1338

andyfengHKU opened this issue Mar 2, 2023 · 1 comment
Assignees
@ray6080

Comments

@andyfengHKU
Copy link
Contributor

Since we are using the CSV reader from arrow. We should no longer maintain our own CSV reader.
@mewim mewim mentioned this issue Mar 3, 2023
Merged
@mewim
Copy link
Member

mewim commented Mar 3, 2023 •
edited

In #1341, I have removed the CSVReader class and renamed the remaining csv_reader to copier_config. @ray6080 Please double check if NodeStructuredStringPropertyTest is still needed and also consider if we should move the CSVReaderConfig to another place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ray6080 ray6080

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ray6080 @mewim @andyfengHKU