Merge pull request #2094 from kuzudb/fix-warning

Fix warning
kuzudb · Sep 27, 2023 · d5c756a · d5c756a
2 parents 3753f71 + cc05da1
commit d5c756a
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/src/function/table_functions.cpp b/src/function/table_functions.cpp
@@ -116,6 +116,9 @@ void ShowTablesFunction::tableFunc(std::pair<offset_t, offset_t> morsel,
         case TableType::RDF: {
             typeString = "RDF";
         } break;
+        default: {
+            throw common::NotImplementedException{"ShowTablesFunction::tableFunc"};
+        }
         };
         outputVectors[1]->setValue(i, typeString);
         outputVectors[2]->setValue(i, tableSchema->comment);

diff --git a/third_party/miniparquet/CMakeLists.txt b/third_party/miniparquet/CMakeLists.txt
@@ -8,6 +8,13 @@ if(POLICY CMP0063)
     cmake_policy(SET CMP0063 NEW)
 endif()
 
+# Certain Clang compiler versions throw "deprecated declarations" warnings for
+# Thrift.h which comes from the Apache thrift library.
+# The workaround, for now, is to disable this warning if the compiler is Clang.
+if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+    add_compile_options(-Wno-deprecated-declarations)
+endif()
+
 project(miniparquet CXX)
 
 include_directories(src/parquet

diff --git a/third_party/miniparquet/src/parquet/parquet_types.h b/third_party/miniparquet/src/parquet/parquet_types.h