🐞 Show more information in plan status regarding the VMs status #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgratch
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1334 +/- ##
==========================================
- Coverage 36.81% 36.50% -0.31%
==========================================
Files 158 159 +1
Lines 2548 2586 +38
Branches 599 589 -10
==========================================
+ Hits 938 944 +6
- Misses 1428 1640 +212
+ Partials 182 2 -180 ☔ View full report in Codecov by Sentry. |
yaacov
reviewed
Sep 24, 2024
packages/forklift-console-plugin/src/modules/Plans/views/list/components/VMsProgressCell.tsx
Outdated
Show resolved
Hide resolved
yaacov
reviewed
Sep 24, 2024
packages/forklift-console-plugin/src/modules/Plans/views/list/components/VMsProgressCell.tsx
Outdated
Show resolved
Hide resolved
yaacov
reviewed
Sep 24, 2024
packages/forklift-console-plugin/src/modules/Plans/views/list/components/VMsProgressCell.tsx
Show resolved
Hide resolved
sgratch
force-pushed
the
show-migrated-vms-popover-status
branch
from
790bf09
to
857804a
Compare
Reference: kubev2v#1282 Reference: kubev2v#1286 For Running/completed Plans, show more information in status columns of plans list table for the VMs status. When clicking on the status label, a popover with the VMs status is displayed now instead of In plans list page -> status column: no information about the status of the completed/canceled VMs is displayed for running/completed plans. So instead of clicking on the status label for jumping to the VMs table, we now display a popover with more VMs information regarding failed, succeded, canceled VMs Signed-off-by: Sharon Gratch <sgratch@redhat.com>
sgratch
force-pushed
the
show-migrated-vms-popover-status
branch
from
857804a
to
8be9054
Compare
|
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #1282
Reference: #1286
In plans list page -> status column -
no information about the status of the completed/canceled VMs is displayed for running/completed plans.
So instead of clicking on the status label for jumping to the VMs table, we now display a popover with more VMs information regarding failed, succeded, canceled VMs.
Before
After
Screencast.from.2024-09-23.17-04-25.webm