Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 [UI] Need to add a comment after 'Cancel' a VM migration #1286

Closed
duduvaa opened this issue Jul 17, 2024 · 1 comment
Closed

🐞 [UI] Need to add a comment after 'Cancel' a VM migration #1286

duduvaa opened this issue Jul 17, 2024 · 1 comment
Assignees
@sgratch
Labels
bug Categorizes issue or PR as related to a bug.
Milestone
2.6.6

Comments

@duduvaa
Copy link

duduvaa commented Jul 17, 2024

While migration is running and choosing to cancel a VM, it needs to add a comment in the plan status.
Total VMs Failed
Total VMs Canceled
Total VMs Passed
@yaacov yaacov changed the title [UI] Need to add a comment after 'Cancel' a VM migration 🐞 [UI] Need to add a comment after 'Cancel' a VM migration Jul 17, 2024
@yaacov yaacov added the bug Categorizes issue or PR as related to a bug. label Jul 17, 2024
@yaacov yaacov added this to the 2.6.4 milestone Jul 17, 2024
@yaacov yaacov mentioned this issue Jul 18, 2024
Closed
@yaacov yaacov modified the milestones: 2.6.4, 2.6.5, 2.6.6 Aug 27, 2024
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Sep 23, 2024
@sgratch
Show more information in plan status regarding the VMs status
790bf09 
Reference: kubev2v#1282
Reference: kubev2v#1286

For Running/completed Plans, show more information in status
columns of plans list table for the VMs status.
When clicking on the status label, a popover with the VMs status is
displayed now instead of

In plans list page -> status column: no information about the status of the completed/canceled VMs is displayed for running/completed plans.

So instead of clicking on the status label for jumping to the VMs table,
we now display a popover with more VMs information regarding failed, succeded,
canceled VMs

Signed-off-by: Sharon Gratch <sgratch@redhat.com>
@sgratch sgratch mentioned this issue Sep 23, 2024
Merged
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Sep 24, 2024
@sgratch
Show more information in plan status regarding the VMs status
857804a 
Reference: kubev2v#1282
Reference: kubev2v#1286

For Running/completed Plans, show more information in status
columns of plans list table for the VMs status.
When clicking on the status label, a popover with the VMs status is
displayed now instead of

In plans list page -> status column: no information about the status of the completed/canceled VMs is displayed for running/completed plans.

So instead of clicking on the status label for jumping to the VMs table,
we now display a popover with more VMs information regarding failed, succeded,
canceled VMs

Signed-off-by: Sharon Gratch <sgratch@redhat.com>
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Sep 24, 2024
@sgratch
Show more information in plan status regarding the VMs status
8be9054 
Reference: kubev2v#1282
Reference: kubev2v#1286

For Running/completed Plans, show more information in status
columns of plans list table for the VMs status.
When clicking on the status label, a popover with the VMs status is
displayed now instead of

In plans list page -> status column: no information about the status of the completed/canceled VMs is displayed for running/completed plans.

So instead of clicking on the status label for jumping to the VMs table,
we now display a popover with more VMs information regarding failed, succeded,
canceled VMs

Signed-off-by: Sharon Gratch <sgratch@redhat.com>
@yaacov
Copy link
Member

yaacov commented Sep 25, 2024

addressed by: #1334

@yaacov yaacov closed this as completed Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgratch sgratch

Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
2.6.6
Development

No branches or pull requests
3 participants
@yaacov @sgratch @duduvaa