Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StatefulSet API version to 1.9 for the Cassandra example #7096

Merged
merged 2 commits into from
Jan 26, 2018

Conversation

cimomo
Copy link
Contributor

@cimomo cimomo commented Jan 26, 2018

Update StatefulSet API version to 1.9 for the Cassandra example.


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Jan 26, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b79bbb4

https://deploy-preview-7096--kubernetes-io-master-staging.netlify.com

@@ -158,7 +158,7 @@ Use `kubectl edit` to modify the size of of a Cassandra StatefulSet.
# and an empty file will abort the edit. If an error occurs while saving this file will be
# reopened with the relevant failures.
#
apiVersion: apps/v1beta2
apiVersion: apps/v1 # for versions before 1.9.0 use apps/v1beta2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 171 should be changed.
if you change the API version, that v1beta1 should be v1 too.
of course original v1beta1 is wrong also.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks!
@zhangxiaoyu-zidif

@zhangxiaoyu-zidif
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2018
@zhangxiaoyu-zidif
Copy link
Contributor

/approve

@cimomo
Copy link
Contributor Author

cimomo commented Jan 26, 2018

There seems to be a bug in the ci-bot? @zhangxiaoyu-zidif
The following file obviously doesn't exist:

Needs approval from an approver in each of these OWNERS Files:
docs/tutorials/stateful-application/cassandra.md/OWNERS

@zhangxiaoyu-zidif
Copy link
Contributor

@cimomo if no owner file in this directory, https://github.com/kubernetes/website/blob/master/OWNERS would be the default one. so do not be worry.

@zhangxiaoyu-zidif
Copy link
Contributor

@zacharysarah @heckj for approve

@heckj
Copy link
Contributor

heckj commented Jan 26, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cimomo, heckj, zhangxiaoyu-zidif

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2018
@k8s-ci-robot k8s-ci-robot merged commit 488655c into kubernetes:master Jan 26, 2018
@cimomo cimomo deleted the cassandra-fix branch January 26, 2018 14:22
chenopis added a commit that referenced this pull request Jan 29, 2018
…henopis-user-journeys

* 'master' of https://github.com/kubernetes/website: (102 commits)
  Change deployment group (#7112)
  fix typos in extending doc (#7110)
  added installation via Powershell Gallery (#6086)
  Update StatefulSet API version to 1.9 for the Cassandra example (#7096)
  Modify the terms by document style (#7026)
  now that phase out in k8s/cluster/ directory, so remove relative docs (#6951)
  Update mysql-wordpress-persistent-volume.md (#7080)
  Update high-availability.md (#7086)
  Feature gates reference documentation (#6364)
  Add link to autoscaler FAQ (#7045)
  Replace regular characters with HTML entities. (#7038)
  Remove unnecessary manual node object creation (#6765)
  upper case restriction doesn't exist (#7003)
  Add an API concepts document and describe terminology and API chunking (#6540)
  Add kube-apiserver, kube-controller-manager, kube-scheduler and etcd to glossary. (#6600)
  Update what-is-kubernetes.md (#6971)
  Fixed the interacting with cluster section for the ubuntu installation (#6905)
  Update weave-network-policy.md (#6960)
  Added AWS eks (#6568)
  Update eviction strategy to include priority (#6949)
  ...

# Conflicts:
#	_data/setup.yml
#	_data/tutorials.yml
#	docs/imported/release/notes.md
bitfield pushed a commit to bitfield/website that referenced this pull request Feb 19, 2018
…rnetes#7096)

* Update StatefulSet API version to 1.9 for the Cassandra example

* Update API version for StatefulSet in the Cassandra example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants