Remove unnecessary manual node object creation #6765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
Deploy preview ready! Built with commit b081edb https://deploy-preview-6765--kubernetes-io-master-staging.netlify.com |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: heckj, tengqm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
chenopis
added a commit
that referenced
this pull request
Jan 29, 2018
…henopis-user-journeys * 'master' of https://github.com/kubernetes/website: (102 commits) Change deployment group (#7112) fix typos in extending doc (#7110) added installation via Powershell Gallery (#6086) Update StatefulSet API version to 1.9 for the Cassandra example (#7096) Modify the terms by document style (#7026) now that phase out in k8s/cluster/ directory, so remove relative docs (#6951) Update mysql-wordpress-persistent-volume.md (#7080) Update high-availability.md (#7086) Feature gates reference documentation (#6364) Add link to autoscaler FAQ (#7045) Replace regular characters with HTML entities. (#7038) Remove unnecessary manual node object creation (#6765) upper case restriction doesn't exist (#7003) Add an API concepts document and describe terminology and API chunking (#6540) Add kube-apiserver, kube-controller-manager, kube-scheduler and etcd to glossary. (#6600) Update what-is-kubernetes.md (#6971) Fixed the interacting with cluster section for the ubuntu installation (#6905) Update weave-network-policy.md (#6960) Added AWS eks (#6568) Update eviction strategy to include priority (#6949) ... # Conflicts: # _data/setup.yml # _data/tutorials.yml # docs/imported/release/notes.md
bitfield
pushed a commit
to bitfield/website
that referenced
this pull request
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2397
This change is