Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Update outdated files in dev-1.27-ko.1 (M44-M50) #41825

Merged
merged 1 commit into from
Jan 26, 2024
Merged

[ko] Update outdated files in dev-1.27-ko.1 (M44-M50) #41825

merged 1 commit into from
Jan 26, 2024

Conversation

YanyChoi
Copy link

@YanyChoi YanyChoi commented Jul 1, 2023

Files Checked & Modified

  • M44. content/en/docs/concepts/scheduling-eviction/assign-pod-node.md | 88(+M) 54(-)
  • M45. content/en/docs/concepts/scheduling-eviction/node-pressure-eviction.md | 70(+M) 70(-)
  • M46. content/en/docs/concepts/scheduling-eviction/pod-priority-preemption.md | 4(+XS) 3(-)
  • M47. content/en/docs/concepts/scheduling-eviction/pod-scheduling-readiness.md | 28(+S) 17(-)
  • M48. content/en/docs/concepts/scheduling-eviction/resource-bin-packing.md | 17(+S) 18(-)
  • M49. content/en/docs/concepts/scheduling-eviction/taint-and-toleration.md | 5(+XS) 0(-)
  • M50. content/en/docs/concepts/scheduling-eviction/topology-spread-constraints.md | 22(+S) 10(-)

Comments

M47 : 영문판의 경우 mermaid 다이어그램을 mermaid 자체 페이지의 유료판 기능을 사용해서 공유했는데, 다이어그램 자체 내용에 차이는 없고 커뮤니티 내에서의 합의사항도 찾을 수 없어 우선 현 상태로 유지하였습니다.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 1, 2023
@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Jul 1, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 1, 2023
@netlify
Copy link

netlify bot commented Jul 2, 2023

Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit dfaf083
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/64c53b4739d11e000867867d
😎 Deploy Preview https://deploy-preview-41825--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jongwooo
Copy link
Member

/assign

Copy link
Member

@jongwooo jongwooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YanyChoi 사소한 사항들 확인해봤습니다. 아래 리뷰 의견 참고하여 업데이트 부탁드립니다.
그리고, f0c032d 부터 288e572까지의 4개의 커밋을 squash를 통해 하나의 커밋으로 합쳐주시면 감사하겠습니다:)

@YanyChoi YanyChoi requested a review from jongwooo July 29, 2023 13:36
@YanyChoi
Copy link
Author

@jongwooo 수정사항 반영했습니다.
밑에 제대로 안봐서 mermaid 공유 칸이 있는줄도 몰랐네요 😅
svg 파일까지 추가했습니다~

[ko] Update outdated files in dev-1.27-ko.1 [M10-15]

ko] Update outdated files in dev-1.27-ko.1 [M44-50]

Revert "[ko] Update outdated files in dev-1.27-ko.1 [M10-15]"

This reverts commit f0c032d.

ko] Update outdated files in dev-1.27-ko.1 [M44-50]
@jongwooo
Copy link
Member

jongwooo commented Jan 1, 2024

@YanyChoi 확인이 늦어 죄송합니다..! 리뷰 꼼꼼하게 반영해주셔서 감사합니다:)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 015582ce3a7181ee03f181c5b544c7dece71f45c

@YanyChoi
Copy link
Author

YanyChoi commented Jan 2, 2024

@jongwooo approve label이 필요한 것 같습니다...!

@jongwooo
Copy link
Member

jongwooo commented Jan 2, 2024

@YanyChoi approve label은 승인자 권한이어서 제가 드리긴 어려울 것 같습니다.. ㅎㅎ 추후에 승인자께서 검토하시고 추가해주실 듯 합니다😁

@jihoon-seo
Copy link
Member

@YanyChoi @jongwooo 고생 많으셨습니다 감사합니다!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jihoon-seo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit ab8a48f into kubernetes:dev-1.27-ko.1 Jan 26, 2024
5 checks passed
@YanyChoi YanyChoi deleted the dev-1.27-ko.1-m44-m50 branch January 27, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants