Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Incorrect topology label in "Pod Topology Spread Constraints" page #45254

Closed
omkensey opened this issue Feb 21, 2024 · 5 comments
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug. language/ko Issues or PRs related to Korean language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. triage/duplicate Indicates an issue is a duplicate of other open issue.

Comments

@omkensey
Copy link

In the English version of the above page, the last paragraph of the Consistency section reads:

You need a mechanism to ensure that all the nodes in a topology domain (such as a cloud provider region) are labelled consistently. To avoid you needing to manually label nodes, most clusters automatically populate well-known labels such as kubernetes.io/hostname. Check whether your cluster supports this.

But in the Korean page's version of that paragraph, the label used as an example is topology.kubernetes.io/hostname which is incorrect.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 21, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dipesh-rawat
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Feb 21, 2024
@dipesh-rawat
Copy link
Member

/retitle [ko] Incorrect topology label in "Pod Topology Spread Constraints" page
/kind bug

@k8s-ci-robot k8s-ci-robot changed the title Korean version of "Pod Topology Spread Constraints" page has an incorrect topology label in the text [ko] Incorrect topology label in "Pod Topology Spread Constraints" page Feb 21, 2024
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 21, 2024
@jihoon-seo
Copy link
Member

@omkensey Thanks for raising this issue.
The outdatedness of that page has been reported in the issue #41613,
and updated to the dev-1.27-ko.1 branch via the PR #41825. (Fixed line)
When the dev-1.27-ko.1 branch gets merged into main in the future, we will be able to check the updated contents.

Considering the aspects above, let me close this issue.
Again, thank you for your contribution!

/triage duplicate
/close

@k8s-ci-robot k8s-ci-robot added the triage/duplicate Indicates an issue is a duplicate of other open issue. label Apr 11, 2024
@k8s-ci-robot
Copy link
Contributor

@jihoon-seo: Closing this issue.

In response to this:

@omkensey Thanks for raising this issue.
The outdatedness of that page has been reported in the issue #41613,
and updated to the dev-1.27-ko.1 branch via the PR #41825. (Fixed line)
When the dev-1.27-ko.1 branch gets merged into main in the future, we will be able to check the updated contents.

Considering the aspects above, let me close this issue.
Again, thank you for your contribution!

/triage duplicate
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. language/ko Issues or PRs related to Korean language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. triage/duplicate Indicates an issue is a duplicate of other open issue.
Projects
None yet
Development

No branches or pull requests

4 participants