Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with deletionTimestamp in https://kubernetes.io/docs/api-reference/v1.8/#objectmeta-v1-meta #6128

Closed
1 of 2 tasks
cben opened this issue Nov 1, 2017 · 2 comments
Closed
1 of 2 tasks

Issue with deletionTimestamp in https://kubernetes.io/docs/api-reference/v1.8/#objectmeta-v1-meta #6128

cben opened this issue Nov 1, 2017 · 2 comments

Comments

@cben
Copy link
Contributor

cben commented Nov 1, 2017 •
edited
Loading

This is a...

  • Feature Request
  • Bug Report

Problem:
ObjectMeta.deletionTimestamp documentation in api docs seems to predate finalizers field and the cascading deletion in progress concept.
It says:

The resource is expected to be deleted (no longer visible from resource lists, and not reachable by name) after the time in this field. Once set, this value may not be unset or be set further into the future, although it may be shortened or the resource may be deleted prior to this time.

IIUC this is no longer true. It does point to https://github.com/kubernetes/community/blob/master/contributors/devel/api-conventions.md#metadata which has an updated definition (emphasis mine):

The resource will be deleted (no longer visible from resource lists, and not reachable by name) after the time in this field except when the object has a finalizer set. In case the finalizer is set the deletion of the object is postponed at least until the finalizer is removed.

Proposed Solution:
Take definition form api-conventions.md.
Perhaps also amend the sentence "This field is set by the server when a graceful deletion is requested by the user, ..." (identical in both) — my impression is graceful deletion was one scenario, but it can also be set in cascading delete / finalizers scenario without any grace period?
I'm just reading the docs and don't know what I'm speaking about!

Page to Update:
Specifically in https://kubernetes.io/docs/api-reference/v1.8/#objectmeta-v1-meta but same text is duplicated in many other places eg. https://kubernetes.io/docs/reference/federation/v1/definitions/#_v1_objectmeta
@wackxu
Copy link
Contributor

wackxu commented Nov 1, 2017

I can help fix it

@wackxu wackxu mentioned this issue Nov 1, 2017
Merged
hh pushed a commit to ii/kubernetes that referenced this issue Nov 3, 2017
Merge pull request kubernetes#54936 from wackxu/deletime
7115596 
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
sttts pushed a commit to sttts/apimachinery that referenced this issue Nov 3, 2017
@k8s-publish-robot
Merge pull request #54936 from wackxu/deletime
9a5ac29 
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 71155962aa10ae233458237e39e61802bf3dab10
@zacharysarah
Copy link
Contributor

Closed by kubernetes/kubernetes#54936

sttts pushed a commit to sttts/apimachinery that referenced this issue Nov 27, 2017
@k8s-publish-robot
Merge pull request #54936 from wackxu/deletime
872ff6e 
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 71155962aa10ae233458237e39e61802bf3dab10
sttts pushed a commit to sttts/apimachinery that referenced this issue Nov 28, 2017
@k8s-publish-robot
Merge pull request #54936 from wackxu/deletime
1aab001 
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 71155962aa10ae233458237e39e61802bf3dab10
sttts pushed a commit to sttts/apimachinery that referenced this issue Nov 28, 2017
@k8s-publish-robot
Merge pull request #54936 from wackxu/deletime
af8ba58 
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 71155962aa10ae233458237e39e61802bf3dab10
sttts pushed a commit to sttts/apimachinery that referenced this issue Nov 28, 2017
@k8s-publish-robot
Merge pull request #54936 from wackxu/deletime
916e8dd 
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 71155962aa10ae233458237e39e61802bf3dab10
sttts pushed a commit to sttts/apimachinery that referenced this issue Nov 28, 2017
@k8s-publish-robot
Merge pull request #54936 from wackxu/deletime
90fe5a5 
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 71155962aa10ae233458237e39e61802bf3dab10
k8s-publishing-bot pushed a commit to k8s-publishing-bot/apimachinery that referenced this issue Nov 29, 2017
@k8s-publish-robot
Merge pull request #54936 from wackxu/deletime
224d979 
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 71155962aa10ae233458237e39e61802bf3dab10
k8s-publishing-bot pushed a commit to k8s-publishing-bot/apimachinery that referenced this issue Dec 7, 2017
@k8s-publish-robot
Merge pull request #54936 from wackxu/deletime
412b7b5 
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 71155962aa10ae233458237e39e61802bf3dab10
akhilerm pushed a commit to akhilerm/apimachinery that referenced this issue Sep 20, 2022
@k8s-publishing-bot
Merge pull request #54936 from wackxu/deletime
1ba951e 
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 71155962aa10ae233458237e39e61802bf3dab10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cben @zacharysarah @wackxu