Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deletionTimestamp with information about finalizer effect. #1177

Conversation

pospispa
Copy link

Updating description of deletionTimestamp as adviced here.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 12, 2017
@grodrigues3
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit f8bd922 into kubernetes:master Oct 12, 2017
hh pushed a commit to ii/kubernetes that referenced this pull request Nov 3, 2017
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
sttts pushed a commit to sttts/apimachinery that referenced this pull request Nov 3, 2017
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 71155962aa10ae233458237e39e61802bf3dab10
sttts pushed a commit to sttts/apimachinery that referenced this pull request Nov 27, 2017
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 71155962aa10ae233458237e39e61802bf3dab10
sttts pushed a commit to sttts/apimachinery that referenced this pull request Nov 28, 2017
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 71155962aa10ae233458237e39e61802bf3dab10
sttts pushed a commit to sttts/apimachinery that referenced this pull request Nov 28, 2017
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 71155962aa10ae233458237e39e61802bf3dab10
sttts pushed a commit to sttts/apimachinery that referenced this pull request Nov 28, 2017
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 71155962aa10ae233458237e39e61802bf3dab10
sttts pushed a commit to sttts/apimachinery that referenced this pull request Nov 28, 2017
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 71155962aa10ae233458237e39e61802bf3dab10
k8s-publishing-bot pushed a commit to k8s-publishing-bot/apimachinery that referenced this pull request Nov 29, 2017
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 71155962aa10ae233458237e39e61802bf3dab10
k8s-publishing-bot pushed a commit to k8s-publishing-bot/apimachinery that referenced this pull request Dec 7, 2017
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 71155962aa10ae233458237e39e61802bf3dab10
akhilerm pushed a commit to akhilerm/apimachinery that referenced this pull request Sep 20, 2022
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update deletionTimestamp with information about finalizer effect

**What this PR does / why we need it**:

ref kubernetes/community#1177

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # kubernetes/website#6128

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: 71155962aa10ae233458237e39e61802bf3dab10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants