Add internal schedule for release notes PRs #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/documentation
k8s-ci-robot
added
the
area/release-team
k8s-ci-robot
added
sig/release
npolshakova
force-pushed
the
npolshak/add-release-notes-schedule-example
branch
from
504c1d6
to
1ce8c2d
Compare
rashansmith
reviewed
May 15, 2024
rashansmith
reviewed
May 15, 2024
|
Hey @npolshakova, great job on getting this done! Overall it looks good, and I've added a few comments. Let me know what you think! |
rashansmith
approved these changes
May 21, 2024
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
/assign @harshanarayana |
k8s-ci-robot
removed
the
lgtm
|
/lgtm /hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
lgtm
|
@npolshakova, please feel free to remove hold whenever PR is ready to merge. 🙂 Thanks for the updates! 🙏 |
Priyankasaggu11929
removed
lgtm
k8s-ci-robot
added
the
approved
npolshakova
force-pushed
the
npolshak/add-release-notes-schedule-example
branch
from
6f403a1
to
34719a7
Compare
k8s-ci-robot
added
area/release-eng
npolshakova
force-pushed
the
npolshak/add-release-notes-schedule-example
branch
from
34719a7
to
57d0425
Compare
k8s-ci-robot
added
approved
npolshakova
force-pushed
the
npolshak/add-release-notes-schedule-example
branch
from
57d0425
to
f0c8048
Compare
saschagrunert
approved these changes
Jun 6, 2024
k8s-ci-robot
added
the
lgtm
|
/unhold /approve |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: npolshakova, Priyankasaggu11929, rashansmith, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind documentation
What this PR does / why we need it:
This adds an example for defining release notes draft PR merge deadline. Currently, the timeline only defines when a branch is created, and we assume to get the PR done sometime before the next branch is made. This would be only internally enforced and used to give status updates.
Previously Release Notes Leads have created similar schedules for assigning shadows to "own" a specific release: https://docs.google.com/spreadsheets/d/1xNNWdh-hFTVgg-zebp0-DdV-gCnx5l3uUv3RikjAzBg/edit?usp=sharing
The 1.30 end of release retro suggested adding a release notes draft PR merge deadline that would be tied to status reports during release team update meetings.
Which issue(s) this PR fixes:
#2498