Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boskos client with the one in sigs.k8s.io/boskos #773

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

MartinForReal
Copy link
Contributor

Replace boskos client with the one in sigs.k8s.io/boskos so that k8s.io/test-infra can be removed.
Part of #771

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 30, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 30, 2023
@MartinForReal
Copy link
Contributor Author

/assign @vteratipally

@MartinForReal
Copy link
Contributor Author

/assign @mmiranda96

@MartinForReal
Copy link
Contributor Author

MartinForReal commented Jul 4, 2023

/assign @Random-Liu

@vteratipally
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 5, 2023
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 5, 2023
@MartinForReal
Copy link
Contributor Author

/test pull-npd-build

Signed-off-by: Fan Shang Xiang <shafan@microsoft.com>
@MartinForReal
Copy link
Contributor Author

@vteratipally I've rebased the pr. Could you please take a look? Thanks!

@MartinForReal
Copy link
Contributor Author

/test pull-npd-build


@MartinForReal
Copy link
Contributor Author

/retest-required

@MartinForReal
Copy link
Contributor Author

/retest

3 similar comments
@MartinForReal
Copy link
Contributor Author

/retest

@MartinForReal
Copy link
Contributor Author

/retest

@MartinForReal
Copy link
Contributor Author

/retest

@mmiranda96
Copy link
Contributor

Test issue has been fixed.
/retest

@MartinForReal
Copy link
Contributor Author

@mmiranda96 Could you please approve the pr? Thanks!

@vteratipally
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MartinForReal, vteratipally

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 09b7fb8 into kubernetes:master Aug 4, 2023
@MartinForReal MartinForReal deleted the shafan/boskos branch August 4, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants