Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MartinForReal as a reviewer #775

Closed
wants to merge 1 commit into from

Conversation

MartinForReal
Copy link
Contributor

@MartinForReal MartinForReal commented Jun 30, 2023

Add MartinForReal as a reviewer

PR:
#756
#760
#769
#773
#774
#793
#806
#820
#811 in review.

Reviewed pr:
#823
#806
#774
#761

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 30, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 30, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jun 30, 2023
@MartinForReal
Copy link
Contributor Author

/test pull-npd-build

@vteratipally
Copy link
Collaborator

Thank you for the contribution, Would you mind the adding the evidence based on the https://github.com/kubernetes/community/blob/master/community-membership.md#requirements-2

@hakman
Copy link
Member

hakman commented Aug 29, 2023

@vteratipally I see that @MartinForReal wants to join as a Reviewer, which has different kind of requirements.
https://github.com/kubernetes/community/blob/master/community-membership.md#reviewer

Pretty sure they are all requirements are met, maybe even for approver status.
/lgtm
/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims August 29, 2023 07:28
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2023
@vteratipally
Copy link
Collaborator

It would be helpful in reviewing the PR with the evidence added based on the requirements.

@dims
Copy link
Member

dims commented Aug 29, 2023

@MartinForReal for the record, can you please add details in the PR body? (as mentioned in https://github.com/kubernetes/community/blob/master/community-membership.md#requirements-1)

- member for at least 3 months
- Primary reviewer for at least 5 PRs to the codebase
- Reviewed or merged at least 20 substantial PRs to the codebase
- Knowledgeable about the codebase
- Sponsored by a subproject approver
- With no objections from other approvers
- Done through PR to update the OWNERS file
- May either self-nominate, be nominated by an approver in this subproject, or be nominated by a robot

Note that sig-node bar is very similar as well https://github.com/kubernetes/community/blob/master/sig-node/sig-node-contributor-ladder.md#reviewer (cc @vteratipally)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2023
Signed-off-by: Fan Shang Xiang <shafan@microsoft.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2023
@MartinForReal
Copy link
Contributor Author

MartinForReal commented Dec 22, 2023

@hakman @vteratipally Would you like to be my sponsor? Thanks!

@hakman
Copy link
Member

hakman commented Dec 22, 2023

@hakman @vteratipally Would you like to be my sponsor? Thanks!

Sure, I'm fine with that.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hakman, MartinForReal
Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MartinForReal
Copy link
Contributor Author

/retest

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants