-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MartinForReal as a reviewer #775
Conversation
/test pull-npd-build |
Thank you for the contribution, Would you mind the adding the evidence based on the https://github.com/kubernetes/community/blob/master/community-membership.md#requirements-2 |
@vteratipally I see that @MartinForReal wants to join as a Reviewer, which has different kind of requirements. Pretty sure they are all requirements are met, maybe even for approver status. |
It would be helpful in reviewing the PR with the evidence added based on the requirements. |
@MartinForReal for the record, can you please add details in the PR body? (as mentioned in https://github.com/kubernetes/community/blob/master/community-membership.md#requirements-1)
Note that sig-node bar is very similar as well https://github.com/kubernetes/community/blob/master/sig-node/sig-node-contributor-ladder.md#reviewer (cc @vteratipally) |
42b002b
to
82f0cd2
Compare
Signed-off-by: Fan Shang Xiang <shafan@microsoft.com>
82f0cd2
to
dd910b9
Compare
@hakman @vteratipally Would you like to be my sponsor? Thanks! |
Sure, I'm fine with that. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hakman, MartinForReal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Add MartinForReal as a reviewer
PR:
#756
#760
#769
#773
#774
#793
#806
#820
#811 in review.
Reviewed pr:
#823
#806
#774
#761