Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump k8s.io to 1.24.15 and replace boskos client #771

Closed
wants to merge 1 commit into from
Closed

bump k8s.io to 1.24.15 and replace boskos client #771

wants to merge 1 commit into from

Conversation

MartinForReal
Copy link
Contributor

@MartinForReal MartinForReal commented Jun 26, 2023 •
edited
Loading

add context. Context
replace boskos client in test-infra with sigs.k8s.io/boskos
bump k8s.io to 1.24.15

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MartinForReal
Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 26, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 26, 2023
@MartinForReal
Copy link
Contributor Author

related: #761

@MartinForReal MartinForReal changed the title bump k8s.io to 1.24.15 and remove boskos client bump k8s.io to 1.24.15 and replace boskos client Jun 26, 2023
@MartinForReal
Copy link
Contributor Author

/assign @vteratipally

@vteratipally
Copy link
Collaborator

add context. Context
Any specific reason for splitting the context

@MartinForReal
Copy link
Contributor Author

because context is required in new k8s client

@MartinForReal
Copy link
Contributor Author

/assign @mmiranda96

@mmiranda96
Copy link
Contributor

Can we split this PR into 2 or more? Adding context can be done before upgrading dependencies. And I think we can do the same with the Boskos client (correct me if I'm wrong on this one).

@vteratipally
Copy link
Collaborator

Can we split this PR into 2 or more? Adding context can be done before upgrading dependencies. And I think we can do the same with the Boskos client (correct me if I'm wrong on this one).

Yes, I agree with Mike. It will be clear if we split the PR in two parts.

This was referenced Jun 30, 2023
Merged
Merged
@MartinForReal
Copy link
Contributor Author

I've opened two pr. And I will bump the dependencies after these two pr has been merged.
Could you please take a look? Thanks! @mmiranda96 @vteratipally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmiranda96 mmiranda96 Awaiting requested review from mmiranda96

@wangzhen127 wangzhen127 Awaiting requested review from wangzhen127

Assignees

@mmiranda96 mmiranda96

@vteratipally vteratipally

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinForReal @k8s-ci-robot @vteratipally @mmiranda96