Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ginkgo version for pull-npd-e2e-test #647

Closed
wants to merge 1 commit into from
Closed

fix ginkgo version for pull-npd-e2e-test #647

wants to merge 1 commit into from

Conversation

notchairmk
Copy link
Contributor

@notchairmk notchairmk commented Feb 19, 2022 •
edited
Loading

  • Currently e2e tests are failing for two apparent reasons:
  • This PR fixes the ginkgo version mismatch by explicitly including ginkgo version used to run e2e tests in go.mod/vendor
    • The sooner we can address ginkgo version mismatch issues the better because this is now bleeding into further e2e test failures since default k/k and test-infra tests are using more recent versions of ginkgo
  • Further PRs will be required to get to update prow jobs
  • Fixes part of Tests ci-npd-e2e-test are failing kubernetes#108166
    • There are additional steps that will need to be taken to fix further e2e tests including correct ginkgo version and CRI runtime changes, but this is a starting point
  • Updates builder dockerfile to go v1.15

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 19, 2022
@notchairmk notchairmk changed the title fix e2e tests, add vendored ginkgo runner fix ginkgo version for e2e tests Feb 19, 2022
@notchairmk
Copy link
Contributor Author

image

@notchairmk notchairmk changed the title fix ginkgo version for e2e tests fix ginkgo version for pull-npd-e2e-test Feb 21, 2022
@oif oif mentioned this pull request Mar 4, 2022
Merged
@vteratipally
Copy link
Collaborator

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: notchairmk, vteratipally
To complete the pull request process, please assign xueweiz after the PR has been reviewed.
You can assign the PR to them by writing /assign @xueweiz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2022
@vteratipally
Copy link
Collaborator

/retest

@k8s-ci-robot
Copy link
Contributor

@notchairmk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags d4ca503 link true /test pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags
pull-npd-e2e-kubernetes-gce-gci d4ca503 link true /test pull-npd-e2e-kubernetes-gce-gci
pull-npd-e2e-kubernetes-gce-gci-custom-flags d4ca503 link true /test pull-npd-e2e-kubernetes-gce-gci-custom-flags
pull-npd-e2e-kubernetes-gce-ubuntu d4ca503 link true /test pull-npd-e2e-kubernetes-gce-ubuntu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@notchairmk
Copy link
Contributor Author

notchairmk commented Mar 10, 2022 •
edited
Loading

note: the CI side of this test was removed in this test-infra PR because of consistently failing

@vteratipally
Copy link
Collaborator

/hold it is moving away from fixing the ginkgo version and failing the other tests where as the ci tests are passing consistently.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2022
@vteratipally
Copy link
Collaborator

/hold

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2022
@k8s-ci-robot
Copy link
Contributor

@notchairmk: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vteratipally
Copy link
Collaborator

/hold cancel

Thank you for the PR, the test is now fixed and we are waiting on a PR to add back the tests to presubmit again

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@wangzhen127 wangzhen127 Awaiting requested review from wangzhen127

Assignees

@vteratipally vteratipally

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@notchairmk @vteratipally @k8s-ci-robot