Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete ci-npd-e2e-test. #25542

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Delete ci-npd-e2e-test. #25542

merged 1 commit into from
Mar 9, 2022

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Mar 8, 2022

@fejta
Delete ci-npd-e2e-test.
815e66e 
It has wrong flags and has been failing for months
@k8s-ci-robot
Copy link
Contributor

@fejta: GitHub didn't allow me to assign the following users: zhenghuiwang.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

It has wrong flags and has been failing for months

https://testgrid.k8s.io/sig-node-node-problem-detector#ci-npd-e2e-test&width=5

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-npd-e2e-test/1500988238561546240#

/assign @xueweiz @zhenghuiwang @Random-Liu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 8, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2022
@fejta
Copy link
Contributor Author

fejta commented Mar 9, 2022

/assign @chaodaiG @BenTheElder

chaodaiG
chaodaiG approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@chaodaiG chaodaiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

let's save some core hours

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 770ea03 into kubernetes:master Mar 9, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 9, 2022
@k8s-ci-robot
Copy link
Contributor

@fejta: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key node-problem-detector-ci.yaml using file config/jobs/kubernetes/node-problem-detector/node-problem-detector-ci.yaml

In response to this:

It has wrong flags and has been failing for months

https://testgrid.k8s.io/sig-node-node-problem-detector#ci-npd-e2e-test&width=5

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-npd-e2e-test/1500988238561546240#

/assign @xueweiz @zhenghuiwang @Random-Liu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta fejta deleted the cookie branch March 9, 2022 21:33
@notchairmk notchairmk mentioned this pull request Mar 10, 2022
Closed
@vteratipally
Copy link
Contributor

vteratipally commented Mar 10, 2022 •
edited
Loading

I was about to submit the same patch.

@vteratipally vteratipally mentioned this pull request Mar 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaodaiG chaodaiG chaodaiG approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@BenTheElder BenTheElder

@Random-Liu Random-Liu

@xueweiz xueweiz

@chaodaiG chaodaiG

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Archived in project
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
7 participants
@fejta @k8s-ci-robot @vteratipally @chaodaiG @BenTheElder @Random-Liu @xueweiz