Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize netcollector implementation and custom /proc mount path #594

Merged
merged 2 commits into from
Apr 11, 2022
Merged

optimize netcollector implementation and custom /proc mount path #594

merged 2 commits into from
Apr 11, 2022

Conversation

oif
Copy link
Contributor

@oif oif commented Jul 20, 2021

Improvements:

  • net collector metrics: optimized register and record
  • custom /proc: supports mount host /proc with a custom path into the NPD container

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @oif!

It looks like this is your first PR to kubernetes/node-problem-detector 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/node-problem-detector has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @oif. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 20, 2021
@oif oif force-pushed the chore/optimize-netcollector-implementation branch from 6e7a107 to c1a382a Compare July 20, 2021 03:32
@oif
Copy link
Contributor Author

oif commented Jul 20, 2021

/assign @wangzhen127

@vteratipally
Copy link
Collaborator

/retest

@vteratipally
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 2, 2021
@vteratipally vteratipally self-requested a review August 2, 2021 16:04
@oif oif force-pushed the chore/optimize-netcollector-implementation branch 2 times, most recently from 67db75a to 5961758 Compare August 3, 2021 02:28
@oif
Copy link
Contributor Author

oif commented Aug 3, 2021

/retest

@oif
Copy link
Contributor Author

oif commented Aug 3, 2021

/cc @vteratipally

@oif
Copy link
Contributor Author

oif commented Aug 3, 2021

/assign @vteratipally

@Random-Liu
Copy link
Member

@vteratipally Will rely on you for the review. :)

@oif
Copy link
Contributor Author

oif commented Aug 31, 2021

/unassign @wangzhen127 @andyxning

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 31, 2021
@oif oif force-pushed the chore/optimize-netcollector-implementation branch from 5961758 to 44685e2 Compare September 1, 2021 02:10
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2021
@oif
Copy link
Contributor Author

oif commented Oct 5, 2021

/assign @wangzhen127

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 4, 2022
@vteratipally
Copy link
Collaborator

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 4, 2022
@Random-Liu
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2022
@oif
Copy link
Contributor Author

oif commented Mar 4, 2022

/test pull-npd-e2e-test
/test pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags

@oif
Copy link
Contributor Author

oif commented Mar 4, 2022 •
edited
Loading

just wait for #647 to resolve test issues

@oif
Copy link
Contributor Author

oif commented Mar 12, 2022

/retest-required

@oif oif force-pushed the chore/optimize-netcollector-implementation branch from 44685e2 to 9c0452f Compare March 12, 2022 06:47
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2022
@k8s-ci-robot
Copy link
Contributor

@oif: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-npd-e2e-test 44685e2 link true /test pull-npd-e2e-test
pull-npd-e2e-kubernetes-gce-gci 9c0452f link true /test pull-npd-e2e-kubernetes-gce-gci
pull-npd-e2e-kubernetes-gce-ubuntu 9c0452f link true /test pull-npd-e2e-kubernetes-gce-ubuntu
pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags 9c0452f link true /test pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags
pull-npd-e2e-kubernetes-gce-gci-custom-flags 9c0452f link true /test pull-npd-e2e-kubernetes-gce-gci-custom-flags

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vteratipally
Copy link
Collaborator

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2022
@oif
Copy link
Contributor Author

oif commented Apr 11, 2022

/retest

@oif
Copy link
Contributor Author

oif commented Apr 11, 2022

@vteratipally may keep going?

@vteratipally
Copy link
Collaborator

/test pull-npd-e2e-kubernetes-gce-gci

@vteratipally
Copy link
Collaborator

/test pull-npd-e2e-kubernetes-gce-gci-custom-flags

@vteratipally
Copy link
Collaborator

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2022
@oif oif force-pushed the chore/optimize-netcollector-implementation branch from 9c0452f to 11ddb5e Compare April 11, 2022 10:15
@oif
Copy link
Contributor Author

oif commented Apr 11, 2022 •
edited
Loading

@vteratipally just rebase master branch, tests working.

need review(then lgtm) after all test succeeded

@vteratipally
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oif, Random-Liu, vteratipally

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 285516d into kubernetes:master Apr 11, 2022
@mmiranda96 mmiranda96 mentioned this pull request Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vteratipally vteratipally vteratipally approved these changes

@andyxning andyxning Awaiting requested review from andyxning

@wangzhen127 wangzhen127 Awaiting requested review from wangzhen127

Assignees

@wangzhen127 wangzhen127

@Random-Liu Random-Liu

@vteratipally vteratipally

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oif @k8s-ci-robot @vteratipally @Random-Liu @k8s-triage-robot @wangzhen127