Consistent sort order for minikube addons list
#2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zcahana Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Can one of the admins verify this patch? |
|
/assign @dlorenc |
|
Note that I didn't add any unit-test for this, but tested manually. zvic@zvic-vbox:~/Workspace/go/src/k8s.io/minikube (sort_addons_list)$ git log -n1 --oneline
02f3014 List addons in a consistent sort order
zvic@zvic-vbox:~/Workspace/go/src/k8s.io/minikube (sort_addons_list)$ make
GOOS=linux go build -tags "container_image_ostree_stub containers_image_openpgp" -ldflags="-X k8s.io/minikube/pkg/version.version=v0.24.1 -X k8s.io/minikube/pkg/version.isoVersion=v0.24.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/vendor/k8s.io/kubernetes/pkg/version.gitCommit=925c127ec6b946659ad0fd596fa959be43f0cc05 -X k8s.io/minikube/vendor/k8s.io/kubernetes/pkg/version.gitVersion=v1.9.0 -X k8s.io/minikube/vendor/k8s.io/kubernetes/pkg/version.gitTreeState=dirty -X k8s.io/minikube/vendor/k8s.io/kubernetes/pkg/version.buildDate=2018-01-22T12:29:24Z -X k8s.io/minikube/vendor/k8s.io/client-go/pkg/version.gitCommit=925c127ec6b946659ad0fd596fa959be43f0cc05 -X k8s.io/minikube/vendor/k8s.io/client-go/pkg/version.gitVersion=v1.9.0 -X k8s.io/minikube/vendor/k8s.io/client-go/pkg/version.gitTreeState=dirty -X k8s.io/minikube/vendor/k8s.io/client-go/pkg/version.buildDate=2018-01-22T12:29:24Z " -a -o out/minikube-linux-amd64 k8s.io/minikube/cmd/minikube
cp ./out/minikube-linux-amd64 ./out/minikube
zvic@zvic-vbox:~/Workspace/go/src/k8s.io/minikube (sort_addons_list)$ ./out/minikube addons list
- addon-manager: enabled
- coredns: disabled
- dashboard: disabled
- default-storageclass: enabled
- efk: disabled
- heapster: disabled
- ingress: disabled
- kube-dns: enabled
- registry: disabled
- registry-creds: disabled
- storage-provisioner: enabled
zvic@zvic-vbox:~/Workspace/go/src/k8s.io/minikube (sort_addons_list)$
zvic@zvic-vbox:~/Workspace/go/src/k8s.io/minikube (sort_addons_list)$ ./out/minikube addons list
- addon-manager: enabled
- coredns: disabled
- dashboard: disabled
- default-storageclass: enabled
- efk: disabled
- heapster: disabled
- ingress: disabled
- kube-dns: enabled
- registry: disabled
- registry-creds: disabled
- storage-provisioner: enabled |
zcahana
force-pushed
the
sort_addons_list
branch
from
59101f0
to
02f3014
Compare
dlorenc
approved these changes
Jan 22, 2018
|
@minikube-bot ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
minikube addons listto list addons in a lexicographic sort order, so that the output is consistent across invocations ofminikube addons list.Resolves #2445.