Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent sort order for minikube addons list #2445

Closed
zcahana opened this issue Jan 22, 2018 · 1 comment
Closed

Consistent sort order for minikube addons list #2445

zcahana opened this issue Jan 22, 2018 · 1 comment
Labels
area/addons kind/feature Categorizes issue or PR as related to a new feature.

Comments

@zcahana
Copy link
Contributor

zcahana commented Jan 22, 2018

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
FEATURE REQUEST

What happened:
When invoking minikube addons list, the order in which addons are displayed is inconsistent, and varies from one invocation to another.

For example:

zvic@zvic-vbox:~$ minikube addons list
- dashboard: disabled
- default-storageclass: enabled
- coredns: disabled
- heapster: disabled
- registry: disabled
- addon-manager: enabled
- ingress: disabled
- registry-creds: disabled
- kube-dns: enabled
zvic@zvic-vbox:~$ 
zvic@zvic-vbox:~$ minikube addons list
- default-storageclass: enabled
- coredns: disabled
- kube-dns: enabled
- ingress: disabled
- registry-creds: disabled
- addon-manager: enabled
- dashboard: disabled
- heapster: disabled
- registry: disabled

What you expected to happen:
It would be nicer if the addons are printed in a consistent sort order.
The simplest approach would be to sort them according to addon name, lexicographically.

If you're ok with this change, I'd be happy to submit a PR.

@zcahana
Copy link
Contributor Author

zcahana commented Jan 22, 2018

The proposed change is small enough so I went ahead and submitted a PR for it (#2446).

@r2d4 r2d4 added kind/feature Categorizes issue or PR as related to a new feature. area/addons labels Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addons kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants