Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for other container runtimes for auto-pause #11834

Merged
merged 3 commits into from
Jul 1, 2021
Merged

Add support for other container runtimes for auto-pause #11834

merged 3 commits into from
Jul 1, 2021

Conversation

andriyDev
Copy link
Contributor

@andriyDev andriyDev commented Jun 30, 2021 •
edited
Loading

fixes #10597.
fixes #11823 (if #11824 is not merged by then).

Behavior after:

Docker 
$ minikube start --base-image=local/kicbase:latest --container-runtime=docker --addons=auto-pause
😄  minikube v1.22.0-beta.0 on Debian rodete
✨  Automatically selected the docker driver. Other choices: kvm2, ssh
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating docker container (CPUs=2, Memory=3900MB) ...
🐳  Preparing Kubernetes v1.20.7 on Docker 20.10.7 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
    ▪ Using image gcr.io/k8s-minikube/auto-pause-hook:v0.0.2
    ▪ auto-pause addon is an alpha feature and still in early development. Please file issues to help us make it better.
    ▪ https://github.com/kubernetes/minikube/labels/co/auto-pause
🌟  Enabled addons: storage-provisioner, default-storageclass, auto-pause
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
$ minikube ssh
docker@minikube:~$ docker ps
CONTAINER ID   IMAGE                                 COMMAND                  CREATED          STATUS       
5981b51fc214   gcr.io/k8s-minikube/auto-pause-hook   "/auto-pause-hook -t…"   2 seconds ago    Up 2 seconds 
9de800cd93fe   6e38f40d628d                          "/storage-provisioner"   5 seconds ago    Up 5 seconds 
27dab6aa24dc   k8s.gcr.io/pause:3.2                  "/pause"                 6 seconds ago    Up 5 seconds 
d031a0e29394   bfe3a36ebd25                          "/coredns -conf /etc…"   13 seconds ago   Up 13 seconds
0358db16df01   k8s.gcr.io/pause:3.2                  "/pause"                 14 seconds ago   Up 13 seconds
32b5c54f5f9a   k8s.gcr.io/pause:3.2                  "/pause"                 14 seconds ago   Up 13 seconds
823b2f566ef2   k8s.gcr.io/pause:3.2                  "/pause"                 14 seconds ago   Up 13 seconds
728fcd18b78a   ff54c88b8ecf                          "/usr/local/bin/kube…"   14 seconds ago   Up 14 seconds
05ca7970e5fe   k8s.gcr.io/pause:3.2                  "/pause"                 14 seconds ago   Up 14 seconds
bf7b036f40dc   38f903b54010                          "kube-scheduler --au…"   37 seconds ago   Up 37 seconds
dde9403027f9   22d1a2072ec7                          "kube-controller-man…"   37 seconds ago   Up 37 seconds
e1c09bd01296   0369cf4303ff                          "etcd --advertise-cl…"   37 seconds ago   Up 37 seconds
7e63b9fdb78f   034671b24f0f                          "kube-apiserver --ad…"   37 seconds ago   Up 37 seconds
8db2abb4d49b   k8s.gcr.io/pause:3.2                  "/pause"                 38 seconds ago   Up 37 seconds
615af82ecfd2   k8s.gcr.io/pause:3.2                  "/pause"                 38 seconds ago   Up 37 seconds
62031ed6a669   k8s.gcr.io/pause:3.2                  "/pause"                 38 seconds ago   Up 37 seconds
98698a4da6fb   k8s.gcr.io/pause:3.2                  "/pause"                 38 seconds ago   Up 37 seconds
docker@minikube:~$ sleep 60 && docker ps
CONTAINER ID   IMAGE                                 COMMAND                  CREATED              STATUS                    
30c0f5e287f5   haproxy                               "docker-entrypoint.s…"   About a minute ago   Up About a minute         
5981b51fc214   gcr.io/k8s-minikube/auto-pause-hook   "/auto-pause-hook -t…"   About a minute ago   Up About a minute         
9de800cd93fe   6e38f40d628d                          "/storage-provisioner"   About a minute ago   Up About a minute (Paused)
27dab6aa24dc   k8s.gcr.io/pause:3.2                  "/pause"                 About a minute ago   Up About a minute (Paused)
d031a0e29394   bfe3a36ebd25                          "/coredns -conf /etc…"   About a minute ago   Up About a minute (Paused)
0358db16df01   k8s.gcr.io/pause:3.2                  "/pause"                 About a minute ago   Up About a minute (Paused)
32b5c54f5f9a   k8s.gcr.io/pause:3.2                  "/pause"                 About a minute ago   Up About a minute         
823b2f566ef2   k8s.gcr.io/pause:3.2                  "/pause"                 About a minute ago   Up About a minute         
728fcd18b78a   ff54c88b8ecf                          "/usr/local/bin/kube…"   About a minute ago   Up About a minute (Paused)
05ca7970e5fe   k8s.gcr.io/pause:3.2                  "/pause"                 About a minute ago   Up About a minute (Paused)
bf7b036f40dc   38f903b54010                          "kube-scheduler --au…"   About a minute ago   Up About a minute (Paused)
dde9403027f9   22d1a2072ec7                          "kube-controller-man…"   About a minute ago   Up About a minute (Paused)
e1c09bd01296   0369cf4303ff                          "etcd --advertise-cl…"   About a minute ago   Up About a minute (Paused)
7e63b9fdb78f   034671b24f0f                          "kube-apiserver --ad…"   About a minute ago   Up About a minute (Paused)
8db2abb4d49b   k8s.gcr.io/pause:3.2                  "/pause"                 About a minute ago   Up About a minute (Paused)
615af82ecfd2   k8s.gcr.io/pause:3.2                  "/pause"                 About a minute ago   Up About a minute (Paused)
62031ed6a669   k8s.gcr.io/pause:3.2                  "/pause"                 About a minute ago   Up About a minute (Paused)
98698a4da6fb   k8s.gcr.io/pause:3.2                  "/pause"                 About a minute ago   Up About a minute (Paused)
docker@minikube:~$ exit
logout
$ kubectl get pods
No resources found in default namespace.
$ minikube ssh
Last login: Wed Jun 30 16:09:41 2021 from 192.168.49.1
docker@minikube:~$ docker ps
CONTAINER ID   IMAGE                                 COMMAND                  CREATED              STATUS           
30c0f5e287f5   haproxy                               "docker-entrypoint.s…"   About a minute ago   Up About a minute
5981b51fc214   gcr.io/k8s-minikube/auto-pause-hook   "/auto-pause-hook -t…"   About a minute ago   Up About a minute
9de800cd93fe   6e38f40d628d                          "/storage-provisioner"   About a minute ago   Up About a minute
27dab6aa24dc   k8s.gcr.io/pause:3.2                  "/pause"                 About a minute ago   Up About a minute
d031a0e29394   bfe3a36ebd25                          "/coredns -conf /etc…"   About a minute ago   Up About a minute
0358db16df01   k8s.gcr.io/pause:3.2                  "/pause"                 About a minute ago   Up About a minute
32b5c54f5f9a   k8s.gcr.io/pause:3.2                  "/pause"                 About a minute ago   Up About a minute
823b2f566ef2   k8s.gcr.io/pause:3.2                  "/pause"                 About a minute ago   Up About a minute
728fcd18b78a   ff54c88b8ecf                          "/usr/local/bin/kube…"   About a minute ago   Up About a minute
05ca7970e5fe   k8s.gcr.io/pause:3.2                  "/pause"                 About a minute ago   Up About a minute
bf7b036f40dc   38f903b54010                          "kube-scheduler --au…"   2 minutes ago        Up 2 minutes     
dde9403027f9   22d1a2072ec7                          "kube-controller-man…"   2 minutes ago        Up 2 minutes     
e1c09bd01296   0369cf4303ff                          "etcd --advertise-cl…"   2 minutes ago        Up 2 minutes     
7e63b9fdb78f   034671b24f0f                          "kube-apiserver --ad…"   2 minutes ago        Up 2 minutes     
8db2abb4d49b   k8s.gcr.io/pause:3.2                  "/pause"                 2 minutes ago        Up 2 minutes     
615af82ecfd2   k8s.gcr.io/pause:3.2                  "/pause"                 2 minutes ago        Up 2 minutes     
62031ed6a669   k8s.gcr.io/pause:3.2                  "/pause"                 2 minutes ago        Up 2 minutes     
98698a4da6fb   k8s.gcr.io/pause:3.2                  "/pause"                 2 minutes ago        Up 2 minutes
containerd 
$ minikube start --base-image=local/kicbase:latest --container-runtime=containerd --addons=auto-pause
😄  minikube v1.22.0-beta.0 on Debian rodete
✨  Automatically selected the docker driver. Other choices: kvm2, ssh
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating docker container (CPUs=2, Memory=3900MB) ...
📦  Preparing Kubernetes v1.20.7 on containerd 1.4.6 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring CNI (Container Networking Interface) ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/auto-pause-hook:v0.0.2
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
    ▪ auto-pause addon is an alpha feature and still in early development. Please file issues to help us make it better.
    ▪ https://github.com/kubernetes/minikube/labels/co/auto-pause
🌟  Enabled addons: storage-provisioner, default-storageclass, auto-pause
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
$ minikube ssh
docker@minikube:~$ sudo runc --root=/run/containerd/runc/k8s.io list
ID                                                                 PID         STATUS 
22af113e55d57320e9d876e2ff6cd852a2f7f74bb4fac84bb4518a1513d58b78   895         running
22f2201975d3b98e187a11530ebaea7bb959aff23276a1c618b2ce301e8dbc1d   893         running
26757b94b61c769e72cee93ba424951b3a7d08beb4a6d3999a0a8f8a7fdd378f   1063        running
35970eb1eccb18834bc79e8e4c9de7537d91e722d4d1c5abe194092e392d286b   1608        running
54541af4c1721de4b8fba90f69ba8785759148712db9f93f350778d2eb677361   889         running
569f18530f49204b63922f59318d0d211efae794dd556702fa45ac14d1c0e6c2   894         running
62cca8ab9c115fe8bb07e8e89361b702445a5e4a50c4c4996cd91e847937adfb   1049        running
6a870e55afa3b68c64c2e905b6fc05dde028695b1a6871764534e60b776b05fc   1040        running
aefac78d109aa9dbb5e20904535e0623650486ac470b568e1e0f27c4af63fef3   1528        running
cb5b9d995dbe255b895bcc8b5e9341d4f92e583d852143702f5e722b9781bc68   1483        running
e6e8bf00814ba0802e6f673f4b901a67d3ab3103e484f66e7b91b9085bf0c5ab   1046        running
e82435b70b52fa1830872c6bb5927c27b18ff0890c216e78fca96e9ad30f63be   1490        running
docker@minikube:~$ sleep 60 && sudo runc --root=/run/containerd/runc/k8s.io list
ID                                                                 PID         STATUS 
173370c53316934afd52e9d92557a84b2500a42c35f48cee5fc81a25b502e565   1965        running
18e6a010aa08f375de16078d48a754e9e96702388b4e2e75425890de91fe1901   1925        running
22af113e55d57320e9d876e2ff6cd852a2f7f74bb4fac84bb4518a1513d58b78   895         running
22f2201975d3b98e187a11530ebaea7bb959aff23276a1c618b2ce301e8dbc1d   893         running
26757b94b61c769e72cee93ba424951b3a7d08beb4a6d3999a0a8f8a7fdd378f   1063        paused 
35970eb1eccb18834bc79e8e4c9de7537d91e722d4d1c5abe194092e392d286b   1608        paused 
45333eb0761dde5091745b66137dc291424a580007f22cdcdb6730ff52eafe5d   2222        running
54541af4c1721de4b8fba90f69ba8785759148712db9f93f350778d2eb677361   889         running
569f18530f49204b63922f59318d0d211efae794dd556702fa45ac14d1c0e6c2   894         running
57973e206454961b55edfcc01bbab5ca9fa52a97f9568438db22624b1588c287   2303        running
62cca8ab9c115fe8bb07e8e89361b702445a5e4a50c4c4996cd91e847937adfb   1049        paused 
6a870e55afa3b68c64c2e905b6fc05dde028695b1a6871764534e60b776b05fc   1040        paused 
6afe41cdb21ffde6906c98af6a97aec3a342ca82573ba1e684fe88c86b94a423   2108        paused 
9dd3d78dc8d017e02abf158b28f3db39192fba0e910cc37ab2445b14dd220f63   1923        running
a72f048d937f9fa2afd77797d10527b3abe3187e5277ac5531bdd17105e08c18   2074        running
aefac78d109aa9dbb5e20904535e0623650486ac470b568e1e0f27c4af63fef3   1528        paused 
cb5b9d995dbe255b895bcc8b5e9341d4f92e583d852143702f5e722b9781bc68   1483        running
e6e8bf00814ba0802e6f673f4b901a67d3ab3103e484f66e7b91b9085bf0c5ab   1046        paused 
e82435b70b52fa1830872c6bb5927c27b18ff0890c216e78fca96e9ad30f63be   1490        running
f9ab84a7b0edd88a8aa5fc0c6143108ffb6eb5da81fba5cf49a8ff8726f046f2   1999        paused 
docker@minikube:~$ exit
logout
$ kubectl get pods
No resources found in default namespace.
$ minikube ssh
Last login: Wed Jun 30 16:13:13 2021 from 192.168.49.1
docker@minikube:~$ sudo runc --root=/run/containerd/runc/k8s.io list
ID                                                                 PID         STATUS 
173370c53316934afd52e9d92557a84b2500a42c35f48cee5fc81a25b502e565   1965        running
18e6a010aa08f375de16078d48a754e9e96702388b4e2e75425890de91fe1901   1925        running
22af113e55d57320e9d876e2ff6cd852a2f7f74bb4fac84bb4518a1513d58b78   895         running
22f2201975d3b98e187a11530ebaea7bb959aff23276a1c618b2ce301e8dbc1d   893         running
26757b94b61c769e72cee93ba424951b3a7d08beb4a6d3999a0a8f8a7fdd378f   1063        running
35970eb1eccb18834bc79e8e4c9de7537d91e722d4d1c5abe194092e392d286b   1608        running
45333eb0761dde5091745b66137dc291424a580007f22cdcdb6730ff52eafe5d   2222        running
54541af4c1721de4b8fba90f69ba8785759148712db9f93f350778d2eb677361   889         running
569f18530f49204b63922f59318d0d211efae794dd556702fa45ac14d1c0e6c2   894         running
57973e206454961b55edfcc01bbab5ca9fa52a97f9568438db22624b1588c287   2303        running
62cca8ab9c115fe8bb07e8e89361b702445a5e4a50c4c4996cd91e847937adfb   1049        running
6a870e55afa3b68c64c2e905b6fc05dde028695b1a6871764534e60b776b05fc   1040        running
6afe41cdb21ffde6906c98af6a97aec3a342ca82573ba1e684fe88c86b94a423   2108        running
9dd3d78dc8d017e02abf158b28f3db39192fba0e910cc37ab2445b14dd220f63   1923        running
a72f048d937f9fa2afd77797d10527b3abe3187e5277ac5531bdd17105e08c18   2074        running
aefac78d109aa9dbb5e20904535e0623650486ac470b568e1e0f27c4af63fef3   1528        running
cb5b9d995dbe255b895bcc8b5e9341d4f92e583d852143702f5e722b9781bc68   1483        running
e6e8bf00814ba0802e6f673f4b901a67d3ab3103e484f66e7b91b9085bf0c5ab   1046        running
e82435b70b52fa1830872c6bb5927c27b18ff0890c216e78fca96e9ad30f63be   1490        running
f9ab84a7b0edd88a8aa5fc0c6143108ffb6eb5da81fba5cf49a8ff8726f046f2   1999        running
CRI-O 
$ minikube start --base-image=local/kicbase:latest --container-runtime=crio --addons=auto-pause
😄  minikube v1.22.0-beta.0 on Debian rodete
✨  Automatically selected the docker driver. Other choices: kvm2, ssh
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating docker container (CPUs=2, Memory=3900MB) ...
🎁  Preparing Kubernetes v1.20.7 on CRI-O 1.20.3 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring CNI (Container Networking Interface) ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
    ▪ Using image gcr.io/k8s-minikube/auto-pause-hook:v0.0.2
    ▪ auto-pause addon is an alpha feature and still in early development. Please file issues to help us make it better.
    ▪ https://github.com/kubernetes/minikube/labels/co/auto-pause
🌟  Enabled addons: storage-provisioner, default-storageclass, auto-pause
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
$ minikube ssh
docker@minikube:~$ sudo runc list
ID                                                                 PID         STATUS 
1910da45bfd382c9fc0c91c7247f8b243ba3d4b5fd7bc9de4b95d1f739d69a78   1156        running
2d7bd7f31a26a1cc2f67610784051c86ad7461c5e67bdf9e51313bb393863ee5   1807        running
7180af9afcc07cb399b501ecc9b349d25c4445c78e4b7a89090808a3f7e40fff   1799        running
7ab347ef8c4631728d63adc2dcfa63bd4db5aaf2fa6df5195e52817397591d7d   1169        running
8c0271e65a17b77fb16c69943416f94ffcb8f7c0cf90bfc7d5b98c665eeb1b7f   1732        running
b291f29bf0bed0ecadd776adbd503a31413bb7ed924ffca03e48aa064a5f500b   1042        running
b39bbaf0a517eb5b229b638c181228ca42c7123e5064ae8f37bedbde6ad264e0   1043        running
bbb30c71d56e7de76ab2ee9606df7e7137f8c496ece3af2488079077c481e4dc   1739        running
c6109a0d187b1c072d66561fe80a4b15a1d084dad672099bbbd5cb31297fb435   1066        running
cf8d26da5fe3da21709d5c4c1f7d63becb3e7c0d2d48ac3d672e5855a32ba95b   1197        running
d2c1e4c2cc4e6a42823cab8a17e450596aeef8abc18e147f2eac6ef8bb8942d1   1045        running
eda628d38ef1e7161befbbf619cf03a055ea38acb32671e5945dd5a4db22bb84   1212        running
docker@minikube:~$ sleep 60 && sudo runc list
ID                                                                 PID         STATUS 
0d5750aa1711199b856ac24dadc43e71a322e63d7510170cb37ae11ecd29b5ec   2290        paused 
0fa74a7b21852efff8f0ea5884c520f898f6b74d839b2baaf2580a4cd169bf54   2214        running
172634d8bbb52d1307aaca2a91ba94d80da1d7fde6281425d30dae04262ed0f5   2679        running
1910da45bfd382c9fc0c91c7247f8b243ba3d4b5fd7bc9de4b95d1f739d69a78   1156        paused 
2984cb73b16f24354657672f72064a5f976086129f66729635c03faff30c94e7   2367        running
2d7bd7f31a26a1cc2f67610784051c86ad7461c5e67bdf9e51313bb393863ee5   1807        paused 
4ee9730d354406fff73a0d85c9aa1907baa6a238b03ab8f1f32e810e51344bbf   2400        paused 
5a7785c6edcdcd1b81d8f8c9e3ce5642502ca6e0d1112c0022e2327b9ededde5   2502        running
7180af9afcc07cb399b501ecc9b349d25c4445c78e4b7a89090808a3f7e40fff   1799        paused 
7ab347ef8c4631728d63adc2dcfa63bd4db5aaf2fa6df5195e52817397591d7d   1169        paused 
8c0271e65a17b77fb16c69943416f94ffcb8f7c0cf90bfc7d5b98c665eeb1b7f   1732        running
b291f29bf0bed0ecadd776adbd503a31413bb7ed924ffca03e48aa064a5f500b   1042        running
b39bbaf0a517eb5b229b638c181228ca42c7123e5064ae8f37bedbde6ad264e0   1043        running
bb0cd0ee08feb05fce92798bed89b57304632db7e7f4e271c3b561a8ca6bc40a   2233        running
bbb30c71d56e7de76ab2ee9606df7e7137f8c496ece3af2488079077c481e4dc   1739        running
c6109a0d187b1c072d66561fe80a4b15a1d084dad672099bbbd5cb31297fb435   1066        running
cf8d26da5fe3da21709d5c4c1f7d63becb3e7c0d2d48ac3d672e5855a32ba95b   1197        paused 
d2c1e4c2cc4e6a42823cab8a17e450596aeef8abc18e147f2eac6ef8bb8942d1   1045        running
e8542cfa901324007152d1d57d4ba5ea33a52c0982ae8bda3393ed4091ad6502   2216        running
eda628d38ef1e7161befbbf619cf03a055ea38acb32671e5945dd5a4db22bb84   1212        paused 
docker@minikube:~$ exit
logout
$ kubectl get pods
No resources found in default namespace.
$ minikube ssh
Last login: Wed Jun 30 16:18:09 2021 from 192.168.49.1
docker@minikube:~$ sudo runc list
ID                                                                 PID         STATUS 
0d5750aa1711199b856ac24dadc43e71a322e63d7510170cb37ae11ecd29b5ec   2290        running
0fa74a7b21852efff8f0ea5884c520f898f6b74d839b2baaf2580a4cd169bf54   2214        running
172634d8bbb52d1307aaca2a91ba94d80da1d7fde6281425d30dae04262ed0f5   2679        running
1910da45bfd382c9fc0c91c7247f8b243ba3d4b5fd7bc9de4b95d1f739d69a78   1156        running
2984cb73b16f24354657672f72064a5f976086129f66729635c03faff30c94e7   2367        running
2d7bd7f31a26a1cc2f67610784051c86ad7461c5e67bdf9e51313bb393863ee5   1807        running
4ee9730d354406fff73a0d85c9aa1907baa6a238b03ab8f1f32e810e51344bbf   2400        running
5a7785c6edcdcd1b81d8f8c9e3ce5642502ca6e0d1112c0022e2327b9ededde5   2502        running
7180af9afcc07cb399b501ecc9b349d25c4445c78e4b7a89090808a3f7e40fff   1799        running
7ab347ef8c4631728d63adc2dcfa63bd4db5aaf2fa6df5195e52817397591d7d   1169        running
8c0271e65a17b77fb16c69943416f94ffcb8f7c0cf90bfc7d5b98c665eeb1b7f   1732        running
b291f29bf0bed0ecadd776adbd503a31413bb7ed924ffca03e48aa064a5f500b   1042        running
b39bbaf0a517eb5b229b638c181228ca42c7123e5064ae8f37bedbde6ad264e0   1043        running
bb0cd0ee08feb05fce92798bed89b57304632db7e7f4e271c3b561a8ca6bc40a   2233        running
bbb30c71d56e7de76ab2ee9606df7e7137f8c496ece3af2488079077c481e4dc   1739        running
c6109a0d187b1c072d66561fe80a4b15a1d084dad672099bbbd5cb31297fb435   1066        running
cf8d26da5fe3da21709d5c4c1f7d63becb3e7c0d2d48ac3d672e5855a32ba95b   1197        running
d2c1e4c2cc4e6a42823cab8a17e450596aeef8abc18e147f2eac6ef8bb8942d1   1045        running
e8542cfa901324007152d1d57d4ba5ea33a52c0982ae8bda3393ed4091ad6502   2216        running
eda628d38ef1e7161befbbf619cf03a055ea38acb32671e5945dd5a4db22bb84   1212        running

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 30, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 30, 2021
@andriyDev
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 30, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11834) |
+----------------+----------+---------------------+
| minikube start | 48.4s    | 49.0s               |
| enable ingress | 37.2s    | 39.0s               |
+----------------+----------+---------------------+

Times for minikube start: 53.0s 48.3s 46.3s 46.9s 47.6s
Times for minikube (PR 11834) start: 49.5s 52.2s 49.3s 46.4s 47.3s

Times for minikube ingress: 35.8s 38.3s 34.2s 41.3s 36.3s
Times for minikube (PR 11834) ingress: 43.3s 37.7s 33.8s 38.3s 41.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11834) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 22.4s               |
| enable ingress | 33.3s    | 33.8s               |
+----------------+----------+---------------------+

Times for minikube start: 21.6s 22.3s 21.8s 22.2s 22.3s
Times for minikube (PR 11834) start: 21.9s 22.5s 22.0s 22.3s 23.0s

Times for minikube ingress: 33.0s 33.5s 33.5s 33.5s 33.0s
Times for minikube (PR 11834) ingress: 33.0s 37.5s 34.5s 33.5s 30.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11834) |
+----------------+----------+---------------------+
| minikube start | 45.1s    | 45.3s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 48.7s 43.4s 47.7s 42.5s 43.1s
Times for minikube (PR 11834) start: 43.8s 47.5s 43.6s 47.7s 44.0s

@minikube-bot
Copy link
Collaborator

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests Flake Rate (%)
TestOffline 1.32 (chart)
TestRunningBinaryUpgrade 1.97 (chart)
TestPause/serial/SecondStartNoReconfiguration 3.29 (chart)
TestStoppedBinaryUpgrade 100.00 (chart)

To see the flake rates of all tests on KVM_Linux_containerd, click here.

@andriyDev
Copy link
Contributor Author

/ok-to-test

@andriyDev
Copy link
Contributor Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @andriyDev, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11834) |
+----------------+----------+---------------------+
| minikube start | 48.6s    | 47.8s               |
| enable ingress | 38.8s    | 35.9s               |
+----------------+----------+---------------------+

Times for minikube start: 52.9s 46.8s 46.7s 45.8s 50.6s
Times for minikube (PR 11834) start: 47.5s 46.2s 48.2s 49.6s 47.5s

Times for minikube ingress: 37.7s 34.8s 36.3s 42.2s 43.3s
Times for minikube (PR 11834) ingress: 34.7s 34.8s 41.7s 34.2s 34.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11834) |
+----------------+----------+---------------------+
| minikube start | 24.7s    | 30.7s               |
| enable ingress | 34.5s    | 34.0s               |
+----------------+----------+---------------------+

Times for minikube (PR 11834) start: 66.6s 22.6s 21.6s 20.9s 21.7s
Times for minikube start: 34.9s 22.5s 22.7s 21.6s 21.6s

Times for minikube ingress: 33.0s 36.9s 33.0s 33.5s 36.0s
Times for minikube (PR 11834) ingress: 33.0s 36.0s 34.0s 33.0s 34.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11834) |
+----------------+----------+---------------------+
| minikube start | 45.1s    | 45.0s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 44.2s 43.0s 47.9s 47.1s 43.0s
Times for minikube (PR 11834) start: 43.8s 47.5s 42.6s 47.5s 43.7s

@sharifelgamal sharifelgamal merged commit 494a24a into kubernetes:master Jul 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andriyDev, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2021
@andriyDev andriyDev deleted the AutoPause branch July 1, 2021 23:04
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11834) |
+----------------+----------+---------------------+
| minikube start | 47.0s    | 48.4s               |
| enable ingress | 37.8s    | 39.1s               |
+----------------+----------+---------------------+

Times for minikube (PR 11834) start: 48.4s 50.6s 48.6s 46.8s 47.4s
Times for minikube start: 46.9s 46.3s 47.4s 46.5s 47.9s

Times for minikube ingress: 36.2s 41.8s 34.2s 35.7s 41.3s
Times for minikube (PR 11834) ingress: 41.7s 34.7s 41.3s 35.7s 41.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11834) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 22.3s               |
| enable ingress | 35.8s    | 36.7s               |
+----------------+----------+---------------------+

Times for minikube start: 21.3s 21.7s 20.9s 21.4s 22.5s
Times for minikube (PR 11834) start: 23.2s 22.5s 22.0s 21.9s 21.9s

Times for minikube (PR 11834) ingress: 34.0s 33.5s 41.4s 37.5s 37.0s
Times for minikube ingress: 35.5s 38.5s 37.5s 33.5s 34.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11834) |
+----------------+----------+---------------------+
| minikube start | 44.9s    | 44.1s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 47.3s 43.1s 43.4s 47.5s 43.0s
Times for minikube (PR 11834) start: 44.1s 43.7s 46.8s 42.8s 43.3s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auto-pause not working - kubectl hangs/fails to connect auto-pause: support non-docker runtimes
5 participants
@andriyDev @minikube-bot @minikube-pr-bot @k8s-ci-robot @sharifelgamal