Make kicbase copy auto-pause binary instead of auto-pause folder

[andriyDev]

fixes #11823.

[minikube-bot]

Can one of the admins verify this patch?

[sharifelgamal]

cc @medyagh

[medyagh]

aah it seems that I broke this when I added arm64 to kicbase https://github.com/medyagh/minikube/blob/da50c644fc1927c2880e008a0a203faf2a1fc79c/deploy/kicbase/Dockerfile#L39

COPY --from=0 /src/cmd/auto-pause /bin/auto-pause

this needs to be changed to

COPY --from=0 /src/cmd/auto-pause/auto-pause /bin/auto-pause

[medyagh]

ok-to-build-image

[minikube-bot]

Hi @andriyDev, building a new kicbase image failed, with the error below:

	<details>
	<pre>
	env DOCKER_CLI_EXPERIMENTAL=enabled docker run --rm --privileged multiarch/qemu-user-static --reset -p yes

Setting /usr/bin/qemu-alpha-static as binfmt interpreter for alpha
Setting /usr/bin/qemu-arm-static as binfmt interpreter for arm
Setting /usr/bin/qemu-armeb-static as binfmt interpreter for armeb
Setting /usr/bin/qemu-sparc-static as binfmt interpreter for sparc
Setting /usr/bin/qemu-sparc32plus-static as binfmt interpreter for sparc32plus
Setting /usr/bin/qemu-sparc64-static as binfmt interpreter for sparc64
Setting /usr/bin/qemu-ppc-static as binfmt interpreter for ppc
Setting /usr/bin/qemu-ppc64-static as binfmt interpreter for ppc64
Setting /usr/bin/qemu-ppc64le-static as binfmt interpreter for ppc64le
Setting /usr/bin/qemu-m68k-static as binfmt interpreter for m68k
Setting /usr/bin/qemu-mips-static as binfmt interpreter for mips
Setting /usr/bin/qemu-mipsel-static as binfmt interpreter for mipsel
Setting /usr/bin/qemu-mipsn32-static as binfmt interpreter for mipsn32
Setting /usr/bin/qemu-mipsn32el-static as binfmt interpreter for mipsn32el
Setting /usr/bin/qemu-mips64-static as binfmt interpreter for mips64
Setting /usr/bin/qemu-mips64el-static as binfmt interpreter for mips64el
Setting /usr/bin/qemu-sh4-static as binfmt interpreter for sh4
Setting /usr/bin/qemu-sh4eb-static as binfmt interpreter for sh4eb
Setting /usr/bin/qemu-s390x-static as binfmt interpreter for s390x
Setting /usr/bin/qemu-aarch64-static as binfmt interpreter for aarch64
Setting /usr/bin/qemu-aarch64_be-static as binfmt interpreter for aarch64_be
Setting /usr/bin/qemu-hppa-static as binfmt interpreter for hppa
Setting /usr/bin/qemu-riscv32-static as binfmt interpreter for riscv32
Setting /usr/bin/qemu-riscv64-static as binfmt interpreter for riscv64
Setting /usr/bin/qemu-xtensa-static as binfmt interpreter for xtensa
Setting /usr/bin/qemu-xtensaeb-static as binfmt interpreter for xtensaeb
Setting /usr/bin/qemu-microblaze-static as binfmt interpreter for microblaze
Setting /usr/bin/qemu-microblazeel-static as binfmt interpreter for microblazeel
Setting /usr/bin/qemu-or1k-static as binfmt interpreter for or1k
env DOCKER_CLI_EXPERIMENTAL=enabled docker buildx rm --builder minikube-builder || true
env DOCKER_CLI_EXPERIMENTAL=enabled docker buildx create --name minikube-builder --buildkitd-flags '--debug' || true
minikube-builder
Image doesn't exist in registry
Image doesn't exist in registry
env DOCKER_CLI_EXPERIMENTAL=enabled docker buildx build -f ./deploy/kicbase/Dockerfile --builder minikube-builder --platform linux/arm64,linux/amd64 -t gcr.io/k8s-minikube/kicbase-builds:v0.0.24-1625083636-11824 -t kicbase/build:v0.0.24-1625083636-11824 --push --build-arg COMMIT_SHA=v1.22.0-beta.0-"fcae5ab10b740e4e426cfd56c80a3c97b41ddc6c" .

	Full logs are at https://storage.cloud.google.com/minikube-builds/logs/11824/022967c/kic_image_build.txt

[andriyDev]

ok-to-build-image

[andriyDev]

ok-to-build-image

[minikube-bot]

Hi @andriyDev, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

[sharifelgamal]

/ok-to-test

[andriyDev]

/retest-this-please

[andriyDev]

/retest-this-please

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11824) |
+----------------+----------+---------------------+
| minikube start | 59.2s    | 58.9s               |
| enable ingress | 40.4s    | 44.7s               |
+----------------+----------+---------------------+

Times for minikube start: 58.5s 59.9s 59.6s 58.7s 59.5s
Times for minikube (PR 11824) start: 60.5s 57.4s 59.5s 54.8s 62.3s

Times for minikube ingress: 40.0s 45.9s 36.7s 36.0s 43.5s
Times for minikube (PR 11824) ingress: 40.3s 45.5s 45.7s 42.8s 48.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11824) |
+----------------+----------+---------------------+
| minikube start | 27.3s    | 32.5s               |
| enable ingress | 33.1s    | 31.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 32.3s 32.6s 34.2s 33.7s 32.7s
Times for minikube (PR 11824) ingress: 28.7s 31.6s 32.4s 31.7s 32.3s

Times for minikube start: 27.7s 26.0s 28.7s 27.3s 26.9s
Times for minikube (PR 11824) start: 55.0s 27.0s 25.7s 27.3s 27.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11824) |
+----------------+----------+---------------------+
| minikube start | 50.8s    | 51.1s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 52.0s 53.8s 49.2s 48.6s 50.6s
Times for minikube (PR 11824) start: 53.3s 53.1s 48.8s 48.9s 51.3s

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andriyDev, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment