Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links after design proposals move #1128

Merged

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Sep 25, 2017

Some links broke when design proposals were organized in #1010. They were mostly fixed in #1116 but a few seem to still be pointing to the old ones.

Takes another stab at #1109.

/cc @grodrigues3

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2017
@nikhita
Copy link
Member Author

nikhita commented Sep 25, 2017

I am not sure about this but noticed that some proposals (example) have the Anayltics link as:

<!-- BEGIN MUNGE: GENERATED_ANALYTICS -->
[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/docs/proposals/kubelet-hypercontainer-runtime.md?pixel)]()
<!-- END MUNGE: GENERATED_ANALYTICS -->

Should this link also be updated?

@spiffxp
Copy link
Member

spiffxp commented Oct 3, 2017

AFAICT, the code that generated that munge has been deleted. I suspect we might even be able to get rid of the links entirely?

Does someone from @kubernetes/sig-docs-maintainers know the state of our google analytics usage? I'm not sure it even applies to .md files in github repos. A glance through kubernetes/* and kubernetes-incubator/* shows many outdated links (eg: the code-of-conduct.md links)

@zacharysarah
Copy link
Contributor

@spiffxp 👋 I can't speak to site analytics per se, and it may be unrelated to the matter at hand, but here's what the search console shows for 404s from links with *.md in the past 30 days:

screen shot 2017-10-05 at 3 12 26 pm

@steveperry-53
Copy link
Contributor

steveperry-53 commented Oct 5, 2017 via email

@steveperry-53
Copy link
Contributor

steveperry-53 commented Oct 5, 2017 via email

@rohitagarwal003
Copy link
Member

/lgtm

The current changes look good. We can fix the analytics links in another PR.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 2da7a97 into kubernetes:master Oct 9, 2017
@nikhita nikhita deleted the fix-link-design-proposal branch October 9, 2017 02:56
MadhavJivrajani pushed a commit to MadhavJivrajani/community that referenced this pull request Nov 30, 2021
Automatic merge from submit-queue.

Fix links after design proposals move

Some links broke when design proposals were organized in kubernetes#1010. They were mostly fixed in kubernetes#1116 but a few seem to still be pointing to the old ones.

Takes another stab at kubernetes#1109.

/cc @grodrigues3
danehans pushed a commit to danehans/community that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants