Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design proposals have lots of broken links to other design proposals #1109

Closed
rohitagarwal003 opened this issue Sep 21, 2017 · 7 comments · Fixed by #1116
Closed

Design proposals have lots of broken links to other design proposals #1109

rohitagarwal003 opened this issue Sep 21, 2017 · 7 comments · Fixed by #1116
Labels
sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.

Comments

@rohitagarwal003
Copy link
Member

#1010 moved design proposals to SIG specific directories but didn't update the internal links from one design proposal to another. So, all proposals that refer to other proposals have broken links now which makes them harder to read.

/cc @grodrigues3 @bgrant0607
@k8s-github-robot
Copy link

@mindprince
There are no sig labels on this issue. Please add a sig label by:

  1. mentioning a sig: @kubernetes/sig-<group-name>-<group-suffix>
    e.g., @kubernetes/sig-contributor-experience-<group-suffix> to notify the contributor experience sig, OR

  2. specifying the label manually: /sig <label>
    e.g., /sig scalability to apply the sig/scalability label

Note: Method 1 will trigger an email to the group. You can find the group list here and label list here.
The <group-suffix> in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals

@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 21, 2017
@bgrant0607
Copy link
Member

@mindprince Could you please send a PR to fix them?

@bgrant0607 bgrant0607 added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 21, 2017
@php-coder
Copy link
Contributor

I'll fix them.

@php-coder php-coder mentioned this issue Sep 21, 2017
Merged
@xiangpengzhao
Copy link
Contributor

@php-coder awesome! @zhangxiaoyu-zidif had similar idea in kubernetes/website#5530 (comment)

Can the tools you used in your PR automatically check the broken links referenced in other repo?

@php-coder
Copy link
Contributor

Can the tools you used in your PR automatically check the broken links referenced in other repo?

I didn't use any tools this time. It was one-liners on shell :)

@xiangpengzhao
Copy link
Contributor

@php-coder thanks! If you try and find some tools workable, feel free to ping @zhangxiaoyu-zidif :)

@duglin
Copy link

duglin commented Sep 21, 2017

sig svc-cat uses this: https://github.com/duglin/vlinker

@nikhita nikhita mentioned this issue Sep 25, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Oct 9, 2017
Merge pull request #1128 from nikhita/fix-link-design-proposal
2da7a97 
Automatic merge from submit-queue.

Fix links after design proposals move

Some links broke when design proposals were organized in #1010. They were mostly fixed in #1116 but a few seem to still be pointing to the old ones.

Takes another stab at #1109.

/cc @grodrigues3
justaugustus pushed a commit to justaugustus/enhancements that referenced this issue Sep 3, 2018
Merge pull request kubernetes#1128 from nikhita/fix-link-design-proposal
ab11e52 
Automatic merge from submit-queue.

Fix links after design proposals move

Some links broke when design proposals were organized in kubernetes/community#1010. They were mostly fixed in kubernetes/community#1116 but a few seem to still be pointing to the old ones.

Takes another stab at kubernetes/community#1109.

/cc @grodrigues3
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this issue Nov 30, 2021
Merge pull request #1128 from nikhita/fix-link-design-proposal
ad1d565 
Automatic merge from submit-queue.

Fix links after design proposals move

Some links broke when design proposals were organized in kubernetes/community#1010. They were mostly fixed in kubernetes/community#1116 but a few seem to still be pointing to the old ones.

Takes another stab at kubernetes/community#1109.

/cc @grodrigues3
MadhavJivrajani pushed a commit to MadhavJivrajani/design-proposals that referenced this issue Dec 1, 2021
@MadhavJivrajani
Merge pull request #1128 from nikhita/fix-link-design-proposal
e242512 
Automatic merge from submit-queue.

Fix links after design proposals move

Some links broke when design proposals were organized in kubernetes/community#1010. They were mostly fixed in kubernetes/community#1116 but a few seem to still be pointing to the old ones.

Takes another stab at kubernetes/community#1109.

/cc @grodrigues3
MadhavJivrajani pushed a commit to MadhavJivrajani/design-proposals that referenced this issue Dec 1, 2021
@MadhavJivrajani
Merge pull request #1128 from nikhita/fix-link-design-proposal
a8644e3 
Automatic merge from submit-queue.

Fix links after design proposals move

Some links broke when design proposals were organized in kubernetes/community#1010. They were mostly fixed in kubernetes/community#1116 but a few seem to still be pointing to the old ones.

Takes another stab at kubernetes/community#1109.

/cc @grodrigues3
MadhavJivrajani pushed a commit to MadhavJivrajani/design-proposals that referenced this issue Dec 1, 2021
Merge pull request #1128 from nikhita/fix-link-design-proposal
a330aa3 
Automatic merge from submit-queue.

Fix links after design proposals move

Some links broke when design proposals were organized in kubernetes/community#1010. They were mostly fixed in kubernetes/community#1116 but a few seem to still be pointing to the old ones.

Takes another stab at kubernetes/community#1109.

/cc @grodrigues3
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this issue Dec 1, 2021
Merge pull request #1128 from nikhita/fix-link-design-proposal
0199d7a 
Automatic merge from submit-queue.

Fix links after design proposals move

Some links broke when design proposals were organized in kubernetes/community#1010. They were mostly fixed in kubernetes/community#1116 but a few seem to still be pointing to the old ones.

Takes another stab at kubernetes/community#1109.

/cc @grodrigues3
MadhavJivrajani pushed a commit to kubernetes/design-proposals-archive that referenced this issue Dec 1, 2021
Merge pull request #1128 from nikhita/fix-link-design-proposal
9b65751 
Automatic merge from submit-queue.

Fix links after design proposals move

Some links broke when design proposals were organized in kubernetes/community#1010. They were mostly fixed in kubernetes/community#1116 but a few seem to still be pointing to the old ones.

Takes another stab at kubernetes/community#1109.

/cc @grodrigues3
danehans pushed a commit to danehans/community that referenced this issue Jul 18, 2023
@zirain
update Huawei SC seat (kubernetes#1109)
0f6bdff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix broken links after moving proposals to subdirs php-coder/community
6 participants
@php-coder @rohitagarwal003 @duglin @bgrant0607 @k8s-github-robot @xiangpengzhao