Upgrade from 0.19.x to 0.20.x leads to fakedynamic.NewSimpleDynamicClient panic

[zbindenren]

With 0.19.x this code works:

func TestArgo(t *testing.T) {
	c := fakedynamic.NewSimpleDynamicClient(runtime.NewScheme()).Resource(
		schema.GroupVersionResource{
			Group:    "argoproj.io",
			Version:  "v1alpha1",
			Resource: "applications",
		},
	)

	c.Namespace("default").List(context.Background(), metav1.ListOptions{})
}

When I update to 0.20.x I get a panic:

=== RUN   TestArgo
--- FAIL: TestArgo (0.00s)
panic: coding error: you must register resource to list kind for every resource you're going to LIST when creating the client.  See NewSimpleDynamicClientWithCustomListKinds or register the list into the scheme: argoproj.io/v1alpha1, Resource=applications out of map[] [recovered]
        panic: coding error: you must register resource to list kind for every resource you're going to LIST when creating the client.  See NewSimpleDynamicClientWithCustomListKinds or register the list into the scheme: argoproj.io/v1alpha1, Resource=applications out of map[]

goroutine 7 [running]:
testing.tRunner.func1.1(0x1347360, 0xc0003c8f40)
        /home/rz/.gimme/versions/go1.15.5.linux.amd64/src/testing/testing.go:1072 +0x30d
testing.tRunner.func1(0xc00042fe00)
        /home/rz/.gimme/versions/go1.15.5.linux.amd64/src/testing/testing.go:1075 +0x41a
panic(0x1347360, 0xc0003c8f40)
        /home/rz/.gimme/versions/go1.15.5.linux.amd64/src/runtime/panic.go:969 +0x1b9
k8s.io/client-go/dynamic/fake.(*dynamicResourceClient).List(0xc000492540, 0x16aa440, 0xc000044128, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /home/rz/golang/pkg/mod/k8s.io/client-go@v0.20.1/dynamic/fake/simple.go:317 +0xcbf
git.pnet.ch/kubernetes/namespace-creator/pkg/kubernetes.TestArgo(0xc00042fe00)
        /home/rz/repos/git.pnet.ch/kubernetes/namespace-creator/pkg/kubernetes/client_test.go:66 +0x1f5
testing.tRunner(0xc00042fe00, 0x15a3508)
        /home/rz/.gimme/versions/go1.15.5.linux.amd64/src/testing/testing.go:1123 +0xef
created by testing.(*T).Run
        /home/rz/.gimme/versions/go1.15.5.linux.amd64/src/testing/testing.go:1168 +0x2b3
FAIL    git.pnet.ch/kubernetes/namespace-creator/pkg/kubernetes 0.015s
FAIL

[kouvaliasnick]

I have exactly the same issue. Has anyone managed to get insights on this?
I have just found the related commit and I will investigate more tomorrow

[cdmurph32]

I ran into the same problem. After looking at the commit @kouvaliasnick found, I got my tests working again by modifying it to use NewSimpleDynamicClientWithCustomListKinds() instead of NewSimpleDynamicClient().
Kind of a pain that you have to explicitly add the list type, especially for v1 types.

client-go/dynamic/fake/simple.go

Line 43 in 20c034c

func NewSimpleDynamicClientWithCustomListKinds(scheme *runtime.Scheme, gvrToListKind map[schema.GroupVersionResource]string, objects ...runtime.Object) *FakeDynamicClient {

[benmoss]

There's an explanation from @deads2k here #949 (comment)

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[benmoss]

/close

[k8s-ci-robot]

@benmoss: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.