-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from 0.19.x to 0.20.x leads to fakedynamic.NewSimpleDynamicClient panic #914
Comments
I have exactly the same issue. Has anyone managed to get insights on this? |
I ran into the same problem. After looking at the commit @kouvaliasnick found, I got my tests working again by modifying it to use NewSimpleDynamicClientWithCustomListKinds() instead of NewSimpleDynamicClient(). client-go/dynamic/fake/simple.go Line 43 in 20c034c
|
There's an explanation from @deads2k here #949 (comment) |
kubernetes/client-go#914 (comment) Signed-off-by: Kingdon Barrett <kingdon@weave.works>
kubernetes/client-go#914 (comment) Signed-off-by: Kingdon Barrett <kingdon@weave.works>
* remove "replace" statement for go-autorest With SOPS upgraded, "go mod tidy" now fails until this is removed. * Resolve client-go issue from upgrade to 1.20 kubernetes/client-go#914 (comment) * register deployments type Signed-off-by: Kingdon Barrett <kingdon@weave.works>
* remove "replace" statement for go-autorest With SOPS upgraded, "go mod tidy" now fails until this is removed. * Resolve client-go issue from upgrade to 1.20 kubernetes/client-go#914 (comment) * register deployments type Signed-off-by: Kingdon Barrett <kingdon@weave.works>
* remove "replace" statement for go-autorest With SOPS upgraded, "go mod tidy" now fails until this is removed. * Resolve client-go issue from upgrade to 1.20 kubernetes/client-go#914 (comment) * register deployments type Signed-off-by: Kingdon Barrett <kingdon@weave.works>
* remove "replace" statement for go-autorest With SOPS upgraded, "go mod tidy" now fails until this is removed. * Resolve client-go issue from upgrade to 1.20 kubernetes/client-go#914 (comment) * register deployments type Signed-off-by: Kingdon Barrett <kingdon@weave.works>
* remove "replace" statement for go-autorest With SOPS upgraded, "go mod tidy" now fails until this is removed. * Resolve client-go issue from upgrade to 1.20 kubernetes/client-go#914 (comment) * register deployments type Signed-off-by: Kingdon Barrett <kingdon@weave.works>
* remove "replace" statement for go-autorest With SOPS upgraded, "go mod tidy" now fails until this is removed. * Resolve client-go issue from upgrade to 1.20 kubernetes/client-go#914 (comment) * register deployments type Signed-off-by: Kingdon Barrett <kingdon@weave.works>
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/close |
@benmoss: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This helps with go install (see <golang/go#44840>). The side-effect upgrade to Kubernetes 1.20 requires explicitly adding the GatewayList / Gateway connection (see <kubernetes/client-go#914>). Signed-off-by: Stephen Kitt <skitt@redhat.com>
For a Fake k8s client we must now explicitly register all resouces we expect to list in the scheme. Otherwise we'll run into kubernetes/client-go#914 Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
For a Fake k8s client we must now explicitly register all resouces we expect to list in the scheme. Otherwise we'll run into kubernetes/client-go#914 Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
For a Fake k8s client we must now explicitly register all resouces we expect to list in the scheme. Otherwise we'll run into kubernetes/client-go#914 Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
For a Fake k8s client we must now explicitly register all resouces we expect to list in the scheme. Otherwise we'll run into kubernetes/client-go#914 Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
For a Fake k8s client we must now explicitly register all resouces we expect to list in the scheme. Otherwise we'll run into kubernetes/client-go#914 Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
For a Fake k8s client we must now explicitly register all resouces we expect to list in the scheme. Otherwise we'll run into kubernetes/client-go#914 Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
For a Fake k8s client we must now explicitly register all resouces we expect to list in the scheme. Otherwise we'll run into kubernetes/client-go#914 Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
For a Fake k8s client we must now explicitly register all resouces we expect to list in the scheme. Otherwise we'll run into kubernetes/client-go#914 Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
For a Fake k8s client we must now explicitly register all resouces we expect to list in the scheme. Otherwise we'll run into kubernetes/client-go#914 Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
For a Fake k8s client we must now explicitly register all resouces we expect to list in the scheme. Otherwise we'll run into kubernetes/client-go#914 Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
For a Fake k8s client we must now explicitly register all resouces we expect to list in the scheme. Otherwise we'll run into kubernetes/client-go#914 Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
With 0.19.x this code works:
When I update to 0.20.x I get a panic:
The text was updated successfully, but these errors were encountered: