-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added docs on how to integrate JobSet #862
Added docs on how to integrate JobSet #862
Conversation
Hi @mcariatm. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retitle Added docs on how to integrate JobSet |
@stuton: Re-titling can only be requested by trusted users, like repository collaborators. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
for #738
Add a section describing https://github.com/kubernetes-sigs/kueue/pull/762/files#r1237461450 |
|
||
### b. Configure the resource needs | ||
|
||
The resource needs of the workload can be configured in the `spec.replicatedJobs`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also mention the replicas
29845d8
to
2451a16
Compare
|
||
### b. Configure the resource needs | ||
|
||
The resource needs of the workload can be configured in the `spec.replicatedJobs`. The first [PriorityClassName](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#priorityclass) of `spec.replicatedJobs` that is not empty will be used as the priority. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Priority is not directly related to resources.
Please do it in a separate heading.
Also don't forget to mention the number of replicas with regards to total resource calculations.
The resource needs of the workload can be configured in the `spec.replicatedJobs`. Should also be taken into account that number of replicas, parallelism and completions affect the resource calculations. | ||
|
||
```yaml | ||
- template: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add replicas here
|
||
### b. Configure the resource needs | ||
|
||
The resource needs of the workload can be configured in the `spec.replicatedJobs`. Should also be taken into account that number of replicas, parallelism and completions affect the resource calculations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I forgot to ask to mention parallelism :(
/release-note-none |
@alculquicondor: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/release-note-edit
|
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mcariatm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Documenting JobSet support
Which issue(s) this PR fixes:
Fixes #738
Special notes for your reviewer: