Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JobSet in Kueue #738

Closed
3 tasks
Tracked by #636
alculquicondor opened this issue May 2, 2023 · 10 comments · Fixed by #762
Closed
3 tasks
Tracked by #636

Support JobSet in Kueue #738

alculquicondor opened this issue May 2, 2023 · 10 comments · Fixed by #762
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@alculquicondor
Copy link
Contributor

What would you like to be added:

The ability to control JobSet startup through Kueue.

Why is this needed:

To support a wide variety of workloads

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@alculquicondor alculquicondor added the kind/feature Categorizes issue or PR as related to a new feature. label May 2, 2023
@alculquicondor
Copy link
Contributor Author

The first release of jobset came up https://github.com/kubernetes-sigs/jobset/releases/tag/v0.1.0

@alculquicondor
Copy link
Contributor Author

/assign @trasc

@mcariatm
Copy link
Contributor

mcariatm commented May 3, 2023

/assign

@alculquicondor
Copy link
Contributor Author

/unassign @trasc

@kannon92
Copy link
Contributor

kannon92 commented May 3, 2023

I helped write the suspend code in Jobset so feel free to tag if you find issues.

@mcariatm
Copy link
Contributor

For initially unsuspend, setting NodeAffinity foreach ReplicatedJob Template should be enough.
But if the jobs are already created the node selectors should be updated on each of them.
I propose to do that in jobset_contolled in resumeJobSetIfNecessary function on Jobset Operator.

@kerthcet
Copy link
Contributor

Any progress on this?

@tenzen-y
Copy link
Member

@mcariatm is working on this at the jobset side.

kubernetes-sigs/jobset#134

@tenzen-y
Copy link
Member

So it will take a bit of time.

@mcariatm
Copy link
Contributor

Yes, I'm still working on it. On both sides kueue and jobset. I think tomorrow I will put all changes for kueue. Working on tests now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants