Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube-vip shoud fail if kube_proxy_strict_arp is false in arp mod #9223

Merged
merged 2 commits into from
Aug 30, 2022
Merged

kube-vip shoud fail if kube_proxy_strict_arp is false in arp mod #9223

merged 2 commits into from
Aug 30, 2022

Conversation

yankay
Copy link
Member

@yankay yankay commented Aug 26, 2022 •
edited by floryut
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Like MetalLB : #5180 ,
The Kube-VIP in ARP-mod should set kube_proxy_strict_arp=false, according to it's official docs: https://github.com/kube-vip/kube-vip/blob/main/docs/kubernetes/arp/index.md

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kube-vip will now fail if `kube_proxy_strict_arp` is set to `false` in arp mode

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2022
@yankay yankay changed the title kube vip shoud fail if kube_proxy_strict_arp is false in arp mod kube-vip shoud fail if kube_proxy_strict_arp is false in arp mod Aug 26, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2022
@yankay yankay force-pushed the fix-kube-vip-strict-arp branch 2 times, most recently from 25461cf to 48e666a Compare August 29, 2022 08:18
@cristicalin
Copy link
Contributor

Thanks @yankay !

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2022
@floryut floryut added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 30, 2022
floryut
floryut approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yankay Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cristicalin,floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b46ddf3 into kubernetes-sigs:master Aug 30, 2022
rptaylor pushed a commit to rptaylor/kubespray that referenced this pull request Aug 30, 2022
@yankay @rptaylor
kube-vip shoud fail if kube_proxy_strict_arp is false in arp mod (kub…
7ca642a 
…ernetes-sigs#9223)

* fix-kube-vip-strict-arp

* fix-kube-vip-strict-arp
enneitex added a commit to enneitex/kubespray that referenced this pull request Sep 2, 2022
@enneitex
Add privileged_without_host_devices support
3a98faa 
[CI] remove opensuse Leap from molecule test blocking CI (kubernetes-sigs#9229)

Fixes for calico_datastore: etcd (kubernetes-sigs#9228)

It seems that PR kubernetes-sigs#8839 broke `calico_datastore: etcd` when it removed ipamconfig support for etcd mode.

This PR fixes some failing tasks when `calico_datastore == etcd`, but it does not restore ipamconfig support for calico in etcd mode. If someone wants to restore ipamconfig support for `calico_datastore: etcd` please submit a follow up PR for that.

kube-vip shoud fail if kube_proxy_strict_arp is false in arp mod (kubernetes-sigs#9223)

* fix-kube-vip-strict-arp

* fix-kube-vip-strict-arp

add runc v1.1.4 (kubernetes-sigs#9230)

Fix typo.

Fix kube_ovn_hw_offload value (kubernetes-sigs#9218)

Fix cloud_init files for different distros (kubernetes-sigs#9232)

Fix abort because calicoctl.sh is not a full path (kubernetes-sigs#9217)

feat: add kubelet systemd service hardening option (kubernetes-sigs#9194)

* feat: add kubelet systemd service hardening option

* refactor: move variable name to kubelet_secure_addresses

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>

* docs: add diagram about kubelet_secure_addresses variable

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>

make calico installation more stable (kubernetes-sigs#9227)

Signed-off-by: hang.jiang <hang.jiang@daocloud.io>

Signed-off-by: hang.jiang <hang.jiang@daocloud.io>

Update security contacts file (kubernetes-sigs#9235)

disable kubelet_authorization_mode_webhook by default (kubernetes-sigs#9238)

add-yankay-to-reviewers (kubernetes-sigs#9247)
@floryut floryut mentioned this pull request Sep 19, 2022
Closed
enneitex added a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
@enneitex
Add privileged_without_host_devices support
8ef4beb 
[CI] remove opensuse Leap from molecule test blocking CI (kubernetes-sigs#9229)

Fixes for calico_datastore: etcd (kubernetes-sigs#9228)

It seems that PR kubernetes-sigs#8839 broke `calico_datastore: etcd` when it removed ipamconfig support for etcd mode.

This PR fixes some failing tasks when `calico_datastore == etcd`, but it does not restore ipamconfig support for calico in etcd mode. If someone wants to restore ipamconfig support for `calico_datastore: etcd` please submit a follow up PR for that.

kube-vip shoud fail if kube_proxy_strict_arp is false in arp mod (kubernetes-sigs#9223)

* fix-kube-vip-strict-arp

* fix-kube-vip-strict-arp

add runc v1.1.4 (kubernetes-sigs#9230)

Fix typo.

Fix kube_ovn_hw_offload value (kubernetes-sigs#9218)

Fix cloud_init files for different distros (kubernetes-sigs#9232)

Fix abort because calicoctl.sh is not a full path (kubernetes-sigs#9217)

feat: add kubelet systemd service hardening option (kubernetes-sigs#9194)

* feat: add kubelet systemd service hardening option

* refactor: move variable name to kubelet_secure_addresses

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>

* docs: add diagram about kubelet_secure_addresses variable

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>

make calico installation more stable (kubernetes-sigs#9227)

Signed-off-by: hang.jiang <hang.jiang@daocloud.io>

Signed-off-by: hang.jiang <hang.jiang@daocloud.io>

Update security contacts file (kubernetes-sigs#9235)

disable kubelet_authorization_mode_webhook by default (kubernetes-sigs#9238)

add-yankay-to-reviewers (kubernetes-sigs#9247)
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@yankay @nolimitkun
kube-vip shoud fail if kube_proxy_strict_arp is false in arp mod (kub…
c8e8961 
…ernetes-sigs#9223)

* fix-kube-vip-strict-arp

* fix-kube-vip-strict-arp
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
@yankay @LuckySB
kube-vip shoud fail if kube_proxy_strict_arp is false in arp mod (kub…
29758dd 
…ernetes-sigs#9223)

* fix-kube-vip-strict-arp

* fix-kube-vip-strict-arp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@liupeng0518 liupeng0518 Awaiting requested review from liupeng0518

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yankay @cristicalin @k8s-ci-robot @floryut