Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix abort because calicoctl.sh is not a full path #9217

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Fix abort because calicoctl.sh is not a full path #9217

merged 1 commit into from
Aug 30, 2022

Conversation

tasekida
Copy link
Contributor

@tasekida tasekida commented Aug 24, 2022 •
edited by floryut
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
Abort because calicoctl.sh is not a full path

Which issue(s) this PR fixes:
Fixes #9214

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix calicoctl.sh path error when getting calico configuration

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 24, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @tasekida. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 24, 2022
@tasekida
Copy link
Contributor Author

I look forward to working with you
/assign @cristicalin

floryut
floryut approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tasekida Thank you
Please cleanup your git history though, a single commit should be enough 👍

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, tasekida

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2022
@floryut
Copy link
Member

floryut commented Aug 24, 2022

Also, as stated by the bot, please remove the - Fixes https://github.com/kubernetes-sigs/kubespray/issues/9214 as the PR link will be added to your commit, and the issue is reference here.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 24, 2022
@cristicalin
Copy link
Contributor

Hi @tasekida , please rebase this PR on latest state of the master branch to be able to pass the CI tests.

@cristicalin
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 220f149 into kubernetes-sigs:master Aug 30, 2022
rptaylor pushed a commit to rptaylor/kubespray that referenced this pull request Aug 30, 2022
@tasekida @rptaylor
Fix abort because calicoctl.sh is not a full path (kubernetes-sigs#9217)
59b7e32
enneitex added a commit to enneitex/kubespray that referenced this pull request Sep 2, 2022
@enneitex
Add privileged_without_host_devices support
3a98faa 
[CI] remove opensuse Leap from molecule test blocking CI (kubernetes-sigs#9229)

Fixes for calico_datastore: etcd (kubernetes-sigs#9228)

It seems that PR kubernetes-sigs#8839 broke `calico_datastore: etcd` when it removed ipamconfig support for etcd mode.

This PR fixes some failing tasks when `calico_datastore == etcd`, but it does not restore ipamconfig support for calico in etcd mode. If someone wants to restore ipamconfig support for `calico_datastore: etcd` please submit a follow up PR for that.

kube-vip shoud fail if kube_proxy_strict_arp is false in arp mod (kubernetes-sigs#9223)

* fix-kube-vip-strict-arp

* fix-kube-vip-strict-arp

add runc v1.1.4 (kubernetes-sigs#9230)

Fix typo.

Fix kube_ovn_hw_offload value (kubernetes-sigs#9218)

Fix cloud_init files for different distros (kubernetes-sigs#9232)

Fix abort because calicoctl.sh is not a full path (kubernetes-sigs#9217)

feat: add kubelet systemd service hardening option (kubernetes-sigs#9194)

* feat: add kubelet systemd service hardening option

* refactor: move variable name to kubelet_secure_addresses

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>

* docs: add diagram about kubelet_secure_addresses variable

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>

make calico installation more stable (kubernetes-sigs#9227)

Signed-off-by: hang.jiang <hang.jiang@daocloud.io>

Signed-off-by: hang.jiang <hang.jiang@daocloud.io>

Update security contacts file (kubernetes-sigs#9235)

disable kubelet_authorization_mode_webhook by default (kubernetes-sigs#9238)

add-yankay-to-reviewers (kubernetes-sigs#9247)
@floryut floryut mentioned this pull request Sep 19, 2022
Closed
enneitex added a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
@enneitex
Add privileged_without_host_devices support
8ef4beb 
[CI] remove opensuse Leap from molecule test blocking CI (kubernetes-sigs#9229)

Fixes for calico_datastore: etcd (kubernetes-sigs#9228)

It seems that PR kubernetes-sigs#8839 broke `calico_datastore: etcd` when it removed ipamconfig support for etcd mode.

This PR fixes some failing tasks when `calico_datastore == etcd`, but it does not restore ipamconfig support for calico in etcd mode. If someone wants to restore ipamconfig support for `calico_datastore: etcd` please submit a follow up PR for that.

kube-vip shoud fail if kube_proxy_strict_arp is false in arp mod (kubernetes-sigs#9223)

* fix-kube-vip-strict-arp

* fix-kube-vip-strict-arp

add runc v1.1.4 (kubernetes-sigs#9230)

Fix typo.

Fix kube_ovn_hw_offload value (kubernetes-sigs#9218)

Fix cloud_init files for different distros (kubernetes-sigs#9232)

Fix abort because calicoctl.sh is not a full path (kubernetes-sigs#9217)

feat: add kubelet systemd service hardening option (kubernetes-sigs#9194)

* feat: add kubelet systemd service hardening option

* refactor: move variable name to kubelet_secure_addresses

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>

* docs: add diagram about kubelet_secure_addresses variable

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>

make calico installation more stable (kubernetes-sigs#9227)

Signed-off-by: hang.jiang <hang.jiang@daocloud.io>

Signed-off-by: hang.jiang <hang.jiang@daocloud.io>

Update security contacts file (kubernetes-sigs#9235)

disable kubelet_authorization_mode_webhook by default (kubernetes-sigs#9238)

add-yankay-to-reviewers (kubernetes-sigs#9247)
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@tasekida @nolimitkun
Fix abort because calicoctl.sh is not a full path (kubernetes-sigs#9217)
3c3461a
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
@tasekida @LuckySB
Fix abort because calicoctl.sh is not a full path (kubernetes-sigs#9217)
6eb0e26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@cristicalin cristicalin Awaiting requested review from cristicalin

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abort because calicoctl.sh is not a full path
4 participants
@tasekida @k8s-ci-robot @floryut @cristicalin