Update cloudflare.md #4583
Merged
Update cloudflare.md #4583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey! I was trying out external-dns using cloudflare. I followed your docs and managed to deploy it successfully on my k3s cluster. While reading the docs and copying pasting the yaml files I noticed there was some inconsistencies with the indentation.. I am no kubernetes expert, I just fixed the problems that were not allowing me to deploy this service and checked the files using yamllint.com While I was at it I also noticed a few errors on the syntax highlighting for code blocks, some had shell where the content was yaml, I fixed those too.. I hope this helps, thank you for this amazing project!
The committers listed above are authorized under a signed CLA. |
k8s-ci-robot
added
the
cncf-cla: no
|
Welcome @tobiabocchi! |
|
Hi @tobiabocchi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-ok-to-test
k8s-ci-robot
added
cncf-cla: yes
|
Thanks @tobiabocchi, you're right. It's far better with correct indentation 👍. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mloiseleur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
truecharts-admin
added a commit
to truecharts/charts
that referenced
this pull request
Sep 5, 2024
…rnal-dns to v0.15.0@338dd8c by renovate (#25969) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [registry.k8s.io/external-dns/external-dns](https://redirect.github.com/kubernetes-sigs/external-dns) | minor | `v0.14.2` -> `v0.15.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/external-dns (registry.k8s.io/external-dns/external-dns)</summary> ### [`v0.15.0`](https://redirect.github.com/kubernetes-sigs/external-dns/releases/tag/v0.15.0) [Compare Source](https://redirect.github.com/kubernetes-sigs/external-dns/compare/v0.14.2...v0.15.0) #### Important notes This release drops a few unmaintained providers. See [kubernetes-sigs/external-dns#4719 as mentioned in [kubernetes-sigs/external-dns#4347. If you need to use any of the previous providers, please use a previous release of external DNS or follow the instructions to implement a webhook provider that supports those providers. #### What's Changed - build(deps): bump actions/checkout from 4.1.5 to 4.1.6 in the dev-dependencies group by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4477 - Update kustomize version for v0.14.2 by [@​Raffo](https://redirect.github.com/Raffo) in [kubernetes-sigs/external-dns#4480 - build(deps): bump the dev-dependencies group with 8 updates by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4478 - update docs to v0.14.2 by [@​Raffo](https://redirect.github.com/Raffo) in [kubernetes-sigs/external-dns#4481 - build(deps): bump GrantBirki/json-yaml-validate from 2.7.1 to 3.0.0 in the dev-dependencies group by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4489 - fix: re-add api-approved.kubernetes.io annotation by [@​morremeyer](https://redirect.github.com/morremeyer) in [kubernetes-sigs/external-dns#4488 - feat(webhooks): pass webhook-\* annotations to webhook providers by [@​Raffo](https://redirect.github.com/Raffo) in [kubernetes-sigs/external-dns#4458 - fix(traefik): Nil pointer exception if legacy traefik is disabled by [@​kbudde](https://redirect.github.com/kbudde) in [kubernetes-sigs/external-dns#4502 - add unifi webhook to readme by [@​onedr0p](https://redirect.github.com/onedr0p) in [kubernetes-sigs/external-dns#4504 - Drop experimental notice in webhook flags by [@​Raffo](https://redirect.github.com/Raffo) in [kubernetes-sigs/external-dns#4507 - feat(coredns): etcd authentication by [@​matthieugouel](https://redirect.github.com/matthieugouel) in [kubernetes-sigs/external-dns#4503 - Bump the dev-dependencies group across 1 directory with 13 updates by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4514 - Add Infoblox webhook provider by [@​k0da](https://redirect.github.com/k0da) in [kubernetes-sigs/external-dns#4513 - 🌱 docs(footer): Add trademark disclaimer by [@​mariasalcedo](https://redirect.github.com/mariasalcedo) in [kubernetes-sigs/external-dns#4529 - chore!: Remove infoblox in-tree provider by [@​mloiseleur](https://redirect.github.com/mloiseleur) in [kubernetes-sigs/external-dns#4516 - Update to Go 1.22.4 by [@​Raffo](https://redirect.github.com/Raffo) in [kubernetes-sigs/external-dns#4534 - Bump the dev-dependencies group across 1 directory with 19 updates by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4536 - Add documentation about etcd HTTPS for CoreDNS provider by [@​AlessandroZanatta](https://redirect.github.com/AlessandroZanatta) in [kubernetes-sigs/external-dns#4538 - chore(chart): Released chart for v0.14.2 by [@​stevehipwell](https://redirect.github.com/stevehipwell) in [kubernetes-sigs/external-dns#4541 - Bump the dev-dependencies group with 4 updates by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4540 - feat(aws): use AWS profiles using .credentials file by [@​roehrijn](https://redirect.github.com/roehrijn) in [kubernetes-sigs/external-dns#3973 - fix(cloudflare): trimSpace on token read from file by [@​simonostendorf](https://redirect.github.com/simonostendorf) in [kubernetes-sigs/external-dns#4515 - docs: upgrade mkdocs and fix broken links by [@​mloiseleur](https://redirect.github.com/mloiseleur) in [kubernetes-sigs/external-dns#4378 - chore(deps): bump github.com/vektah/gqlparser/v2 from 2.5.1 to 2.5.14 by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4546 - chore(deps): bump github.com/Azure/azure-sdk-for-go/sdk/azidentity from 1.5.2 to 1.6.0 by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4544 - chore(deps): bump the dev-dependencies group across 1 directory with 19 updates by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4562 - chore(deps): bump actions/checkout from 4.1.6 to 4.1.7 in the dev-dependencies group by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4547 - feat(rfc2136): add PTR optional support by [@​angeloxx](https://redirect.github.com/angeloxx) in [kubernetes-sigs/external-dns#4283 - Update cloudflare.md by [@​tobiabocchi](https://redirect.github.com/tobiabocchi) in [kubernetes-sigs/external-dns#4583 - feat!: update GRPCRoute client from v1alpha2 to stable v1 by [@​thameezb](https://redirect.github.com/thameezb) in [kubernetes-sigs/external-dns#4567 - docs(annotations): note how to set multiple hostnames by [@​hopkinsth](https://redirect.github.com/hopkinsth) in [kubernetes-sigs/external-dns#4602 - chore(deps): bump the dev-dependencies group across 1 directory with 2 updates by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4604 - Gateway API: Revert Gateway and HTTPRoute objects from v1 to v1beta1 by [@​abursavich](https://redirect.github.com/abursavich) in [kubernetes-sigs/external-dns#4610 - chore(deps): bump google.golang.org/grpc from 1.64.0 to 1.64.1 by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4600 - chore(deps): bump the dev-dependencies group across 1 directory with 37 updates by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4655 - docs: fix broken link by [@​ilmax](https://redirect.github.com/ilmax) in [kubernetes-sigs/external-dns#4662 - azure-private-dns: Fix LoadBalancer example by [@​orgads](https://redirect.github.com/orgads) in [kubernetes-sigs/external-dns#4663 - AWS: Change documentation to use Helm values by [@​pier-oliviert](https://redirect.github.com/pier-oliviert) in [kubernetes-sigs/external-dns#4577 - chore(deps): bump the dev-dependencies group across 1 directory with 10 updates by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4668 - Improve MinEventInterval compliance with docs by [@​tjamet](https://redirect.github.com/tjamet) in [kubernetes-sigs/external-dns#3400 - Add provider cache by [@​tjamet](https://redirect.github.com/tjamet) in [kubernetes-sigs/external-dns#4597 - chore: update maintainers by [@​mloiseleur](https://redirect.github.com/mloiseleur) in [kubernetes-sigs/external-dns#4679 - fix(helm): make use of resource values for webhook by [@​crutonjohn](https://redirect.github.com/crutonjohn) in [kubernetes-sigs/external-dns#4560 - Fix AWS Cloud Map docs: annotation key/value pairs must be strings by [@​mjlshen](https://redirect.github.com/mjlshen) in [kubernetes-sigs/external-dns#4683 - Webhook provider helm chart fixes by [@​kimsondrup](https://redirect.github.com/kimsondrup) in [kubernetes-sigs/external-dns#4643 - chore(deps): bump the dev-dependencies group across 1 directory with 16 updates by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4684 - chore(deps): bump GrantBirki/json-yaml-validate from 3.0.0 to 3.1.0 in the dev-dependencies group by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4685 - Add tutorial to DynamoDB registry docs by [@​mjlshen](https://redirect.github.com/mjlshen) in [kubernetes-sigs/external-dns#4686 - chore(deps): bump GrantBirki/json-yaml-validate from 3.1.0 to 3.2.0 in the dev-dependencies group by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4700 - chore(deps): bump GrantBirki/json-yaml-validate from 3.2.0 to 3.2.1 in the dev-dependencies group by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4702 - chore: upgrade ExternalDNS to go 1.23 by [@​mloiseleur](https://redirect.github.com/mloiseleur) in [kubernetes-sigs/external-dns#4698 - feat: add annotation and label filters to Ambassador Host Source by [@​KyleMartin901](https://redirect.github.com/KyleMartin901) in [kubernetes-sigs/external-dns#2633 - Add RouterOS provider to README.md by [@​benfiola](https://redirect.github.com/benfiola) in [kubernetes-sigs/external-dns#4714 - feat: support dual stack for gateway api by [@​thameezb](https://redirect.github.com/thameezb) in [kubernetes-sigs/external-dns#4469 - chore(deps): bump actions/setup-python from 5.1.1 to 5.2.0 in the dev-dependencies group by [@​dependabot](https://redirect.github.com/dependabot) in [kubernetes-sigs/external-dns#4712 - chore: remove unmaintained providers by [@​mloiseleur](https://redirect.github.com/mloiseleur) in [kubernetes-sigs/external-dns#4719 #### Images docker pull registry.k8s.io/external-dns/external-dns:v0.15.0 #### New Contributors - [@​kbudde](https://redirect.github.com/kbudde) made their first contribution in [kubernetes-sigs/external-dns#4502 - [@​matthieugouel](https://redirect.github.com/matthieugouel) made their first contribution in [kubernetes-sigs/external-dns#4503 - [@​mariasalcedo](https://redirect.github.com/mariasalcedo) made their first contribution in [kubernetes-sigs/external-dns#4529 - [@​AlessandroZanatta](https://redirect.github.com/AlessandroZanatta) made their first contribution in [kubernetes-sigs/external-dns#4538 - [@​roehrijn](https://redirect.github.com/roehrijn) made their first contribution in [kubernetes-sigs/external-dns#3973 - [@​simonostendorf](https://redirect.github.com/simonostendorf) made their first contribution in [kubernetes-sigs/external-dns#4515 - [@​angeloxx](https://redirect.github.com/angeloxx) made their first contribution in [kubernetes-sigs/external-dns#4283 - [@​tobiabocchi](https://redirect.github.com/tobiabocchi) made their first contribution in [kubernetes-sigs/external-dns#4583 - [@​thameezb](https://redirect.github.com/thameezb) made their first contribution in [kubernetes-sigs/external-dns#4567 - [@​hopkinsth](https://redirect.github.com/hopkinsth) made their first contribution in [kubernetes-sigs/external-dns#4602 - [@​ilmax](https://redirect.github.com/ilmax) made their first contribution in [kubernetes-sigs/external-dns#4662 - [@​orgads](https://redirect.github.com/orgads) made their first contribution in [kubernetes-sigs/external-dns#4663 - [@​pier-oliviert](https://redirect.github.com/pier-oliviert) made their first contribution in [kubernetes-sigs/external-dns#4577 - [@​crutonjohn](https://redirect.github.com/crutonjohn) made their first contribution in [kubernetes-sigs/external-dns#4560 - [@​mjlshen](https://redirect.github.com/mjlshen) made their first contribution in [kubernetes-sigs/external-dns#4683 - [@​kimsondrup](https://redirect.github.com/kimsondrup) made their first contribution in [kubernetes-sigs/external-dns#4643 - [@​KyleMartin901](https://redirect.github.com/KyleMartin901) made their first contribution in [kubernetes-sigs/external-dns#2633 - [@​benfiola](https://redirect.github.com/benfiola) made their first contribution in [kubernetes-sigs/external-dns#4714 **Full Changelog**: kubernetes-sigs/external-dns@v0.14.2...v0.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC42Ny41IiwidXBkYXRlZEluVmVyIjoiMzguNjcuNSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJhdXRvbWVyZ2UiLCJ1cGRhdGUvZG9ja2VyL2dlbmVyYWwvbm9uLW1ham9yIl19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I was trying out external-dns using cloudflare. I followed your docs and managed to deploy it successfully on my k3s cluster. While reading the docs and copying pasting the yaml files I noticed there was some inconsistencies with the indentation.. I am no kubernetes expert, I just fixed the problems that were not allowing me to deploy this service and checked the files using yamllint.com While I was at it I also noticed a few errors on the syntax highlighting for code blocks, some had shell where the content was yaml, I fixed those too.. I hope this helps, thank you for this amazing project!
Description
Fixes #ISSUE
Checklist