Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Infoblox webhook provider #4513

Merged
merged 1 commit into from
May 29, 2024

Conversation

k0da
Copy link
Contributor

@k0da k0da commented May 28, 2024

Description
This add external-dns-infoblox-webhook implementation to the list of webhook providers

Checklist

  • Unit tests updated
  • End user documentation updated

Signed-off-by: Dinar Valeev <k0da@opensuse.org>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 28, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @k0da. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 28, 2024
@k0da k0da mentioned this pull request May 28, 2024
2 tasks
@mloiseleur
Copy link
Contributor

mloiseleur commented May 29, 2024

Nice !
Thanks 👍
/lgtm
@szuecs @Raffo Do you think this mean we can remove the internal one ? cf #4347

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2024
@Raffo
Copy link
Contributor

Raffo commented May 29, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 29, 2024
@Raffo
Copy link
Contributor

Raffo commented May 29, 2024

@mloiseleur yes, I'd be up for removing the infoblox implementation that is in tree. It's going to be a breaking change and I know infoblox had quite a bit of users, but we don't have analytics (and don't want ever to collect them) so I think we can proceed in a later PR to remove the provider.

@Raffo
Copy link
Contributor

Raffo commented May 29, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit bed56b7 into kubernetes-sigs:master May 29, 2024
16 checks passed
truecharts-admin added a commit to truecharts/charts that referenced this pull request Sep 5, 2024
…rnal-dns to v0.15.0@338dd8c by renovate (#25969)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[registry.k8s.io/external-dns/external-dns](https://redirect.github.com/kubernetes-sigs/external-dns)
| minor | `v0.14.2` -> `v0.15.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>kubernetes-sigs/external-dns
(registry.k8s.io/external-dns/external-dns)</summary>

###
[`v0.15.0`](https://redirect.github.com/kubernetes-sigs/external-dns/releases/tag/v0.15.0)

[Compare
Source](https://redirect.github.com/kubernetes-sigs/external-dns/compare/v0.14.2...v0.15.0)

#### Important notes

This release drops a few unmaintained providers. See
[kubernetes-sigs/external-dns#4719
as mentioned in
[kubernetes-sigs/external-dns#4347.
If you need to use any of the previous providers, please use a previous
release of external DNS or follow the instructions to implement a
webhook provider that supports those providers.

#### What's Changed

- build(deps): bump actions/checkout from 4.1.5 to 4.1.6 in the
dev-dependencies group by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[kubernetes-sigs/external-dns#4477
- Update kustomize version for v0.14.2 by
[@&#8203;Raffo](https://redirect.github.com/Raffo) in
[kubernetes-sigs/external-dns#4480
- build(deps): bump the dev-dependencies group with 8 updates by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[kubernetes-sigs/external-dns#4478
- update docs to v0.14.2 by
[@&#8203;Raffo](https://redirect.github.com/Raffo) in
[kubernetes-sigs/external-dns#4481
- build(deps): bump GrantBirki/json-yaml-validate from 2.7.1 to 3.0.0 in
the dev-dependencies group by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[kubernetes-sigs/external-dns#4489
- fix: re-add api-approved.kubernetes.io annotation by
[@&#8203;morremeyer](https://redirect.github.com/morremeyer) in
[kubernetes-sigs/external-dns#4488
- feat(webhooks): pass webhook-\* annotations to webhook providers by
[@&#8203;Raffo](https://redirect.github.com/Raffo) in
[kubernetes-sigs/external-dns#4458
- fix(traefik): Nil pointer exception if legacy traefik is disabled by
[@&#8203;kbudde](https://redirect.github.com/kbudde) in
[kubernetes-sigs/external-dns#4502
- add unifi webhook to readme by
[@&#8203;onedr0p](https://redirect.github.com/onedr0p) in
[kubernetes-sigs/external-dns#4504
- Drop experimental notice in webhook flags by
[@&#8203;Raffo](https://redirect.github.com/Raffo) in
[kubernetes-sigs/external-dns#4507
- feat(coredns): etcd authentication by
[@&#8203;matthieugouel](https://redirect.github.com/matthieugouel) in
[kubernetes-sigs/external-dns#4503
- Bump the dev-dependencies group across 1 directory with 13 updates by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[kubernetes-sigs/external-dns#4514
- Add Infoblox webhook provider by
[@&#8203;k0da](https://redirect.github.com/k0da) in
[kubernetes-sigs/external-dns#4513
- 🌱 docs(footer): Add trademark disclaimer by
[@&#8203;mariasalcedo](https://redirect.github.com/mariasalcedo) in
[kubernetes-sigs/external-dns#4529
- chore!: Remove infoblox in-tree provider by
[@&#8203;mloiseleur](https://redirect.github.com/mloiseleur) in
[kubernetes-sigs/external-dns#4516
- Update to Go 1.22.4 by
[@&#8203;Raffo](https://redirect.github.com/Raffo) in
[kubernetes-sigs/external-dns#4534
- Bump the dev-dependencies group across 1 directory with 19 updates by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[kubernetes-sigs/external-dns#4536
- Add documentation about etcd HTTPS for CoreDNS provider by
[@&#8203;AlessandroZanatta](https://redirect.github.com/AlessandroZanatta)
in
[kubernetes-sigs/external-dns#4538
- chore(chart): Released chart for v0.14.2 by
[@&#8203;stevehipwell](https://redirect.github.com/stevehipwell) in
[kubernetes-sigs/external-dns#4541
- Bump the dev-dependencies group with 4 updates by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[kubernetes-sigs/external-dns#4540
- feat(aws): use AWS profiles using .credentials file by
[@&#8203;roehrijn](https://redirect.github.com/roehrijn) in
[kubernetes-sigs/external-dns#3973
- fix(cloudflare): trimSpace on token read from file by
[@&#8203;simonostendorf](https://redirect.github.com/simonostendorf) in
[kubernetes-sigs/external-dns#4515
- docs: upgrade mkdocs and fix broken links by
[@&#8203;mloiseleur](https://redirect.github.com/mloiseleur) in
[kubernetes-sigs/external-dns#4378
- chore(deps): bump github.com/vektah/gqlparser/v2 from 2.5.1 to 2.5.14
by [@&#8203;dependabot](https://redirect.github.com/dependabot) in
[kubernetes-sigs/external-dns#4546
- chore(deps): bump github.com/Azure/azure-sdk-for-go/sdk/azidentity
from 1.5.2 to 1.6.0 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[kubernetes-sigs/external-dns#4544
- chore(deps): bump the dev-dependencies group across 1 directory with
19 updates by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[kubernetes-sigs/external-dns#4562
- chore(deps): bump actions/checkout from 4.1.6 to 4.1.7 in the
dev-dependencies group by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[kubernetes-sigs/external-dns#4547
- feat(rfc2136): add PTR optional support by
[@&#8203;angeloxx](https://redirect.github.com/angeloxx) in
[kubernetes-sigs/external-dns#4283
- Update cloudflare.md by
[@&#8203;tobiabocchi](https://redirect.github.com/tobiabocchi) in
[kubernetes-sigs/external-dns#4583
- feat!: update GRPCRoute client from v1alpha2 to stable v1 by
[@&#8203;thameezb](https://redirect.github.com/thameezb) in
[kubernetes-sigs/external-dns#4567
- docs(annotations): note how to set multiple hostnames by
[@&#8203;hopkinsth](https://redirect.github.com/hopkinsth) in
[kubernetes-sigs/external-dns#4602
- chore(deps): bump the dev-dependencies group across 1 directory with 2
updates by [@&#8203;dependabot](https://redirect.github.com/dependabot)
in
[kubernetes-sigs/external-dns#4604
- Gateway API: Revert Gateway and HTTPRoute objects from v1 to v1beta1
by [@&#8203;abursavich](https://redirect.github.com/abursavich) in
[kubernetes-sigs/external-dns#4610
- chore(deps): bump google.golang.org/grpc from 1.64.0 to 1.64.1 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[kubernetes-sigs/external-dns#4600
- chore(deps): bump the dev-dependencies group across 1 directory with
37 updates by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[kubernetes-sigs/external-dns#4655
- docs: fix broken link by
[@&#8203;ilmax](https://redirect.github.com/ilmax) in
[kubernetes-sigs/external-dns#4662
- azure-private-dns: Fix LoadBalancer example by
[@&#8203;orgads](https://redirect.github.com/orgads) in
[kubernetes-sigs/external-dns#4663
- AWS: Change documentation to use Helm values by
[@&#8203;pier-oliviert](https://redirect.github.com/pier-oliviert) in
[kubernetes-sigs/external-dns#4577
- chore(deps): bump the dev-dependencies group across 1 directory with
10 updates by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[kubernetes-sigs/external-dns#4668
- Improve MinEventInterval compliance with docs by
[@&#8203;tjamet](https://redirect.github.com/tjamet) in
[kubernetes-sigs/external-dns#3400
- Add provider cache by
[@&#8203;tjamet](https://redirect.github.com/tjamet) in
[kubernetes-sigs/external-dns#4597
- chore: update maintainers by
[@&#8203;mloiseleur](https://redirect.github.com/mloiseleur) in
[kubernetes-sigs/external-dns#4679
- fix(helm): make use of resource values for webhook by
[@&#8203;crutonjohn](https://redirect.github.com/crutonjohn) in
[kubernetes-sigs/external-dns#4560
- Fix AWS Cloud Map docs: annotation key/value pairs must be strings by
[@&#8203;mjlshen](https://redirect.github.com/mjlshen) in
[kubernetes-sigs/external-dns#4683
- Webhook provider helm chart fixes by
[@&#8203;kimsondrup](https://redirect.github.com/kimsondrup) in
[kubernetes-sigs/external-dns#4643
- chore(deps): bump the dev-dependencies group across 1 directory with
16 updates by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[kubernetes-sigs/external-dns#4684
- chore(deps): bump GrantBirki/json-yaml-validate from 3.0.0 to 3.1.0 in
the dev-dependencies group by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[kubernetes-sigs/external-dns#4685
- Add tutorial to DynamoDB registry docs by
[@&#8203;mjlshen](https://redirect.github.com/mjlshen) in
[kubernetes-sigs/external-dns#4686
- chore(deps): bump GrantBirki/json-yaml-validate from 3.1.0 to 3.2.0 in
the dev-dependencies group by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[kubernetes-sigs/external-dns#4700
- chore(deps): bump GrantBirki/json-yaml-validate from 3.2.0 to 3.2.1 in
the dev-dependencies group by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[kubernetes-sigs/external-dns#4702
- chore: upgrade ExternalDNS to go 1.23 by
[@&#8203;mloiseleur](https://redirect.github.com/mloiseleur) in
[kubernetes-sigs/external-dns#4698
- feat: add annotation and label filters to Ambassador Host Source by
[@&#8203;KyleMartin901](https://redirect.github.com/KyleMartin901) in
[kubernetes-sigs/external-dns#2633
- Add RouterOS provider to README.md by
[@&#8203;benfiola](https://redirect.github.com/benfiola) in
[kubernetes-sigs/external-dns#4714
- feat: support dual stack for gateway api by
[@&#8203;thameezb](https://redirect.github.com/thameezb) in
[kubernetes-sigs/external-dns#4469
- chore(deps): bump actions/setup-python from 5.1.1 to 5.2.0 in the
dev-dependencies group by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[kubernetes-sigs/external-dns#4712
- chore: remove unmaintained providers by
[@&#8203;mloiseleur](https://redirect.github.com/mloiseleur) in
[kubernetes-sigs/external-dns#4719

#### Images

    docker pull registry.k8s.io/external-dns/external-dns:v0.15.0

#### New Contributors

- [@&#8203;kbudde](https://redirect.github.com/kbudde) made their first
contribution in
[kubernetes-sigs/external-dns#4502
- [@&#8203;matthieugouel](https://redirect.github.com/matthieugouel)
made their first contribution in
[kubernetes-sigs/external-dns#4503
- [@&#8203;mariasalcedo](https://redirect.github.com/mariasalcedo) made
their first contribution in
[kubernetes-sigs/external-dns#4529
-
[@&#8203;AlessandroZanatta](https://redirect.github.com/AlessandroZanatta)
made their first contribution in
[kubernetes-sigs/external-dns#4538
- [@&#8203;roehrijn](https://redirect.github.com/roehrijn) made their
first contribution in
[kubernetes-sigs/external-dns#3973
- [@&#8203;simonostendorf](https://redirect.github.com/simonostendorf)
made their first contribution in
[kubernetes-sigs/external-dns#4515
- [@&#8203;angeloxx](https://redirect.github.com/angeloxx) made their
first contribution in
[kubernetes-sigs/external-dns#4283
- [@&#8203;tobiabocchi](https://redirect.github.com/tobiabocchi) made
their first contribution in
[kubernetes-sigs/external-dns#4583
- [@&#8203;thameezb](https://redirect.github.com/thameezb) made their
first contribution in
[kubernetes-sigs/external-dns#4567
- [@&#8203;hopkinsth](https://redirect.github.com/hopkinsth) made their
first contribution in
[kubernetes-sigs/external-dns#4602
- [@&#8203;ilmax](https://redirect.github.com/ilmax) made their first
contribution in
[kubernetes-sigs/external-dns#4662
- [@&#8203;orgads](https://redirect.github.com/orgads) made their first
contribution in
[kubernetes-sigs/external-dns#4663
- [@&#8203;pier-oliviert](https://redirect.github.com/pier-oliviert)
made their first contribution in
[kubernetes-sigs/external-dns#4577
- [@&#8203;crutonjohn](https://redirect.github.com/crutonjohn) made
their first contribution in
[kubernetes-sigs/external-dns#4560
- [@&#8203;mjlshen](https://redirect.github.com/mjlshen) made their
first contribution in
[kubernetes-sigs/external-dns#4683
- [@&#8203;kimsondrup](https://redirect.github.com/kimsondrup) made
their first contribution in
[kubernetes-sigs/external-dns#4643
- [@&#8203;KyleMartin901](https://redirect.github.com/KyleMartin901)
made their first contribution in
[kubernetes-sigs/external-dns#2633
- [@&#8203;benfiola](https://redirect.github.com/benfiola) made their
first contribution in
[kubernetes-sigs/external-dns#4714

**Full Changelog**:
kubernetes-sigs/external-dns@v0.14.2...v0.15.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC42Ny41IiwidXBkYXRlZEluVmVyIjoiMzguNjcuNSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJhdXRvbWVyZ2UiLCJ1cGRhdGUvZG9ja2VyL2dlbmVyYWwvbm9uLW1ham9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants