Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSPP] Proposal for Unknown Task Recognition Algorithm Reproduction based on Lifelong Learning of Ianvs #41

Merged
merged 9 commits into from
Feb 22, 2023

Conversation

Frank-lilinjie
Copy link
Contributor

Proposal for Unknown Task Recognition Algorithm Reproduction based on Lifelong Learning of Ianvs.
This PR is a proposal that project aims to reproduce the CVPR2021 paper "Learning placeholders for open-set recognition" in the Semantic Segmentation dataset. This paper proposes placeholders that imitate the emergence of new classes, thus helping to transform closed-set training into open-set training.

This PR is a modification of the last PR

Signed-off-by: Frank-lilinjie <lilinjie@bupt.edu.cn>
Signed-off-by: Frank-lilinjie <lilinjie@bupt.edu.cn>
Signed-off-by: Frank-lilinjie <lilinjie@bupt.edu.cn>
Signed-off-by: Frank-lilinjie <lilinjie@bupt.edu.cn>
1. Reproducing the algorithm from the CVPR2021 paper "Learning placeholders for open-set recognition".
2. Achieving an accuracy of 0.9 for unknown task recognition.
3. Making unknown category recognition modules according to Ianvs architecture and contextual relationship to store in the lib library, so that the algorithm can be used on demand.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test report in goals #26 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Received and completed it.

Frank-lilinjie and others added 4 commits October 25, 2022 17:04
Signed-off-by: Frank-lilinjie <lilinjie@bupt.edu.cn>
Signed-off-by: Frank-lilinjie <lilinjie@bupt.edu.cn>
Signed-off-by: Frank-lilinjie <lilinjie@bupt.edu.cn>
@MooreZheng
Copy link
Collaborator

MooreZheng commented Jan 29, 2023

/lgtm

@jaypume
Copy link
Member

jaypume commented Jan 29, 2023

The PR is perfect, but there are some minor issues about git commit convention that should be noted.

For commit history of Ianvs repository more readable and cleaner, I suggest to squash the commits by git rebase -i kubeedge/main, to keep the number of commit to 1~3, and to make the commit message more concrete.

More details can be refered as following:

  • 'Merge branch 'kubeedge:main' into main', it can be remove by the command git rebase
  • 'update proposal', it can be more concrete like 'added someting to proposal', or just squash it to commit of proposal
  • 'modify test report', it can be mocre concrete like 'removed/added someting to the test report'
  • ...

these are just some examples, you can write it according to your commit content.

@jaypume jaypume merged commit 1194fbb into kubeedge:main Feb 22, 2023
wyoung1 pushed a commit to wyoung1/ianvs that referenced this pull request Sep 25, 2024
[OSPP] Proposal for Unknown Task Recognition Algorithm Reproduction based on Lifelong Learning of Ianvs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants