[OSPP] The codes of Unknown Task Recognition Algorithm Reproduction based on Lifelong Learning of Ianvs #42
Conversation
| transforms.Resize([32,32]), | ||
| transforms.ToTensor() | ||
| ]) | ||
| #import pdb |
There was a problem hiding this comment.
Annotated codes should be removed.
| #pdb.set_trace() | ||
| InferenceData=data_transforms(Image.open(x_data[0][0])) | ||
| device = 'cuda' if torch.cuda.is_available() else 'cpu' | ||
| pthfile = "./examples/curb-detection/lifelong_learning_bench/testalgorithms/rfnet/results/Epochofprose17.pth" |
There was a problem hiding this comment.
The value of "pthfile" should be assigned in init function by a passed parameter.
| @ClassFactory.register(ClassType.UTD, alias="UnseenSampleRecognitionByScene") | ||
| class UnseenSampleRecognitionByScene: | ||
| def __init__(self, **kwargs): | ||
| self.model_path = kwargs.get("model_path") |
There was a problem hiding this comment.
It seems that this parameter is not utilized.
| __all__ = ('UnseenSampleRecognitionByScene',) | ||
|
|
||
| @ClassFactory.register(ClassType.UTD, alias="UnseenSampleRecognitionByScene") | ||
| class UnseenSampleRecognitionByScene: |
There was a problem hiding this comment.
Add documentation comments to make this class more clarified.
| hyperparameters: | ||
| - model_path: | ||
| values: | ||
| - "./examples/curb-detection/lifelong_learning_bench/testalgorithms/rfnet/models/Epochofprose17.pth" |
There was a problem hiding this comment.
The model file "Epochofprose17.pth" has no origin which should be provided in readme.
|
@Frank-lilinjie: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
The code is overall fine but the conflict need to be resolved by fetching the latest version |
| @@ -0,0 +1,48 @@ | |||
| from typing import List, Any, Tuple | |||
There was a problem hiding this comment.
The origin reproduced paper should be referred by comment at the beginning of the code
Frank-lilinjie
force-pushed
the
feature-lifelong-n
branch
from
38bf1f3
to
c908199
Compare
Frank-lilinjie
force-pushed
the
feature-lifelong-n
branch
2 times, most recently
from
7daff08
to
3834b8e
Compare
…orithm update algorithms delete annotated codes refer the origin reproduced p add class documentation upload Readme Modify folder name add an example modify readme Supplementary curb-detection cases Signed-off-by: Frank-lilinjie <lilinjie@bupt.edu.cn>
Frank-lilinjie
force-pushed
the
feature-lifelong-n
branch
from
4591f7f
to
d6b39f7
Compare
|
/lgtm |
|
lgtm |
|
/approve |
[OSPP] The codes of Unknown Task Recognition Algorithm Reproduction based on Lifelong Learning of Ianvs
The PR of the proposal is in PR
This PR is merged in the branch named feature-lifelong-n.
This PR is about the codes of Unknown Task Recognition Algorithm Reproduction based on Lifelong Learning of Ianvs.
This PR is a modification of the last PR