Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unknown task process #71

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

xiaomoguhzz
Copy link
Contributor

What type of PR is this?
add new feature

What this PR does / why we need it:
This pull request adds two unknown process handling algorithms and publishes a benchmark on the open-source dataset 'yaoba', which will attract more developers to join and expand the 'ianvs' community.
Which issue(s) this PR fixes:

None
Fixes #

Signed-off-by: xiaomoguhzz <179760844@qq.com>
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xiaomoguhzz Welcome to KubeEdge SIG AI! Thank you and good to see the pull request.

Here are also two suggestions for your consideration.

  1. Following the community instruction, such a large pull request typically requires a proposal detailedly describing what this pull request aims to do.
  2. Unknown task processing is a key component in lifelong learning. The pull request should work in ianvs - Lifelong Learning, instead of ianvs - SingleTaskLearning.

@MooreZheng
Copy link
Collaborator

MooreZheng commented Aug 23, 2023

Hi @xiaomoguhzz Welcome to KubeEdge SIG AI! Thank you and good to see the pull request.
Here are two comments before merging it.

  1. Following the community instruction, such a large pull request typically requires a proposal detailedly describing what this pull request aims to do.
  2. Unknown task processing, in fact, is a key component in lifelong learning. The pull request should work in ianvs - Lifelong Learning, instead of ianvs - SingleTaskLearning.

For the first comment, an proposal example may be helpful for you

@MooreZheng
Copy link
Collaborator

/lgtm

2 similar comments
@hsj576
Copy link
Member

hsj576 commented Jun 21, 2024

/lgtm

@jaypume
Copy link
Member

jaypume commented Jun 21, 2024

/lgtm

@jaypume jaypume merged commit 5c48872 into kubeedge:main Jun 21, 2024
wyoung1 pushed a commit to wyoung1/ianvs that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants