returning and then print #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
opened pr for go-sec failing issue #261 |
|
why ginkgo-test is failing? ig it is not because of my changes or is it |
|
@PrimalPimmy can you run the ginkgo test workflow again, it is working locally |
|
@PrimalPimmy you can review the pr |
|
@Prateeknandle can you the linting issue that is shown in the files changed section? |
updated |
|
@rksharma95 can we merge this or any review if you want to provide ? |
|
@Prateeknandle can you please squash your commits then we can merge this. |
Prateeknandle
force-pushed
the
refractor_discover
branch
from
e250411
to
82905ec
Compare
|
@rksharma95 do we need to squah |
don't squash instead undo it and do |
Prateeknandle
force-pushed
the
refractor_discover
branch
2 times, most recently
from
f733734
to
1677e61
Compare
Prateeknandle
force-pushed
the
refractor_discover
branch
from
8e8cb02
to
a86fabf
Compare
Signed-off-by: Prateeknandle <prateeknandle@gmail.com>
Prateeknandle
force-pushed
the
refractor_discover
branch
from
0305343
to
6ae99dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prateeknandle prateeknandle@gmail.com
closes #241
refractoring discover api:
changes :
ConvertPolicy()is calledPolicy()func, when comand is usedafter this we can use discover api to get the discovered policies rather than executing command in code.