Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor discover pkg apis #241

Closed
rksharma95 opened this issue Jan 13, 2023 · 2 comments · Fixed by #260
Closed

refactor discover pkg apis #241

rksharma95 opened this issue Jan 13, 2023 · 2 comments · Fixed by #260

Comments

@rksharma95
Copy link
Contributor

Currently discover pkg apis i.e. ConvertPolicy() and Policy() and are not usable outside. The discovered policies are printed to stdout only. if we can make these apis to return the encoded policies then we can utilize them outside. for example, we can leverage these apis in ginkgo based auto-testing framework for discovery-engine where it will no longer required to handle policy data from standard output.
@rksharma95 rksharma95 mentioned this issue Jan 13, 2023
Merged
@Prateeknandle Prateeknandle mentioned this issue Feb 9, 2023
Merged
@Prateeknandle
Copy link
Contributor

Hey @rksharma95 can we also do te same for summary api, want to ask is it doable for summary?

@rksharma95
Copy link
Contributor Author

Hey @rksharma95 can we also do te same for summary api, want to ask is it doable for summary?

Yes it is. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

returning and then print Prateeknandle/kubearmor-client
2 participants
@Prateeknandle @rksharma95