feat: implement LogUp scheme #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insun35
requested review from
chokobole,
dongchangYoo,
TomTaehoonKim and
ashjeong
Insun35
force-pushed
the
feat/implement-logup-scheme
branch
3 times, most recently
from
feb2a27
to
e0f3423
Compare
Insun35
force-pushed
the
feat/implement-logup-scheme
branch
3 times, most recently
from
35d5ddf
to
8a314d3
Compare
Insun35
force-pushed
the
feat/implement-logup-scheme
branch
4 times, most recently
from
d144562
to
6f6be38
Compare
Insun35
force-pushed
the
feat/implement-logup-scheme
branch
3 times, most recently
from
71cf1d6
to
ca0d474
Compare
chokobole
reviewed
May 30, 2024
tachyon/zk/plonk/constraint_system/constraint_system_unittest.cc
Outdated
Show resolved
Hide resolved
tachyon/zk/plonk/constraint_system/constraint_system_unittest.cc
Outdated
Show resolved
Hide resolved
tachyon/zk/plonk/constraint_system/constraint_system_unittest.cc
Outdated
Show resolved
Hide resolved
|
Please remove this statement from the commit body of feat(zk): add constraint_system lookup logic for LookupsMap
|
|
Please add links to the rust reference code to every single commit! |
|
You need to add license of Geometry Research. Does Scroll take this code from here, right? |
|
Please change the type of fix(zk): fix wrong iterator access, feat(zk): add circuit test flags for LogUp and feat(zk): implement MultiLookupCircuit to |
chokobole
reviewed
May 30, 2024
Insun35
force-pushed
the
feat/implement-logup-scheme
branch
4 times, most recently
from
aae25a7
to
b3d6f86
Compare
Insun35
force-pushed
the
feat/implement-logup-scheme
branch
from
8cb3ce2
to
ea1ae1e
Compare
Add `btree_map_stringifier` and `lookup_tracker_stringifier`.
Insun35
force-pushed
the
feat/implement-logup-scheme
branch
from
ea1ae1e
to
7147174
Compare
chokobole
reviewed
Jun 13, 2024
Insun35
force-pushed
the
feat/implement-logup-scheme
branch
from
7147174
to
844a9de
Compare
`MultiLookupCircuit` to be introduced in the following commit requires 2^8 `kMaxExtendedDomainSize`.
Introduce `MultiLookupCircuit` for testing `LogDerivativeHalo2` scheme. See https://github.com/scroll-tech/halo2/blob/1070391642dd64b2d68b47ec246cba9e35bd3c15/halo2_proofs/tests/plonk_api.rs
Insun35
force-pushed
the
feat/implement-logup-scheme
branch
from
844a9de
to
8ad250a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement logarithmic derivative lookup scheme.
Logarithmic derivatives translate products of linear factors into sums of their reciprocals, turning zeroes into simple poles of same multiplicity. It reduces computation cost using grand sum argument instead of grand product argument.
See Paper 2022/1530
Referenced Scroll Halo2 implementation.
We named Logup not MVLookup because this implementation uses univariate polynomial commitment scheme.