feat(zk): implement MultiLookupCircuit

Introduce MultiLookupCircuit for testing LogUp scheme. See https://github.com/scroll-tech/halo2/blob/1070391642dd64b2d68b47ec246cba9e35bd3c15/halo2_proofs/tests/plonk_api.rs
kroma-network · May 26, 2024 · 8a314d3 · 8a314d3
1 parent 8993785
commit 8a314d3
Show file tree

Hide file tree

Showing 6 changed files with 1,342 additions and 0 deletions.
diff --git a/tachyon/zk/plonk/examples/BUILD.bazel b/tachyon/zk/plonk/examples/BUILD.bazel
@@ -32,6 +32,7 @@ tachyon_cc_library(
         "//tachyon/zk/base/commitments:gwc_extension",
         "//tachyon/zk/base/commitments:shplonk_extension",
         "//tachyon/zk/lookup/halo2:scheme",
+        "//tachyon/zk/lookup/logup:scheme",
         "//tachyon/zk/plonk/examples/fibonacci:fibonacci1_circuit",
         "//tachyon/zk/plonk/examples/fibonacci:fibonacci2_circuit",
         "//tachyon/zk/plonk/examples/fibonacci:fibonacci3_circuit",
@@ -46,6 +47,8 @@ tachyon_cc_library(
     srcs = ["circuit_test.cc"],
     hdrs = ["circuit_test.h"],
     deps = [
+        ":multi_lookup_circuit",
+        ":multi_lookup_circuit_test_data",
         ":point",
         ":shuffle_circuit",
         ":shuffle_circuit_test_data",
@@ -76,6 +79,19 @@ tachyon_cc_library(
     hdrs = ["point.h"],
 )
 
+tachyon_cc_library(
+    name = "multi_lookup_circuit",
+    hdrs = ["multi_lookup_circuit.h"],
+    deps = ["//tachyon/zk/plonk/constraint_system:circuit"],
+)
+
+tachyon_cc_library(
+    name = "multi_lookup_circuit_test_data",
+    testonly = True,
+    hdrs = ["multi_lookup_circuit_test_data.h"],
+    deps = COMMON_TEST_DATA_DEPS,
+)
+
 tachyon_cc_library(
     name = "shuffle_circuit",
     hdrs = ["shuffle_circuit.h"],
@@ -118,6 +134,15 @@ tachyon_cc_library(
     deps = COMMON_TEST_DATA_DEPS + ["//tachyon/base:range"],
 )
 
+tachyon_cc_unittest(
+    name = "multi_lookup_circuit_test",
+    srcs = ["multi_lookup_circuit_test.cc"],
+    deps = COMMON_TEST_DEPS + [
+        ":multi_lookup_circuit",
+        ":multi_lookup_circuit_test_data",
+    ],
+)
+
 tachyon_cc_unittest(
     name = "shuffle_circuit_test",
     srcs = ["shuffle_circuit_test.cc"],

diff --git a/tachyon/zk/plonk/examples/circuit_test.cc b/tachyon/zk/plonk/examples/circuit_test.cc
@@ -13,6 +13,8 @@
 #include "tachyon/zk/plonk/examples/fibonacci/fibonacci2_circuit_test_data.h"
 #include "tachyon/zk/plonk/examples/fibonacci/fibonacci3_circuit.h"
 #include "tachyon/zk/plonk/examples/fibonacci/fibonacci3_circuit_test_data.h"
+#include "tachyon/zk/plonk/examples/multi_lookup_circuit.h"
+#include "tachyon/zk/plonk/examples/multi_lookup_circuit_test_data.h"
 #include "tachyon/zk/plonk/examples/shuffle_circuit.h"
 #include "tachyon/zk/plonk/examples/shuffle_circuit_test_data.h"
 #include "tachyon/zk/plonk/examples/simple_circuit.h"
@@ -597,4 +599,18 @@ template class CircuitTest<
     Fibonacci3TestData<Fibonacci3Circuit<BN254SHPlonk::Field, V1FloorPlanner>,
                        BN254SHPlonk, BN254Halo2LS>>;
 
+template class CircuitTest<
+    TestArguments<MultiLookupCircuit<BN254SHPlonk::Field, SimpleFloorPlanner>,
+                  BN254SHPlonk, BN254LogUpLS>,
+    MultiLookupTestData<
+        MultiLookupCircuit<BN254SHPlonk::Field, SimpleFloorPlanner>,
+        BN254SHPlonk, BN254LogUpLS>>;
+
+template class CircuitTest<
+    TestArguments<MultiLookupCircuit<BN254SHPlonk::Field, SimpleFloorPlanner>,
+                  BN254GWC, BN254LogUpLS>,
+    MultiLookupTestData<
+        MultiLookupCircuit<BN254SHPlonk::Field, SimpleFloorPlanner>, BN254GWC,
+        BN254LogUpLS>>;
+
 }  // namespace tachyon::zk::plonk
diff --git a/tachyon/zk/plonk/examples/circuit_test_type_traits.h b/tachyon/zk/plonk/examples/circuit_test_type_traits.h
@@ -7,6 +7,7 @@
 #include "tachyon/zk/base/commitments/gwc_extension.h"
 #include "tachyon/zk/base/commitments/shplonk_extension.h"
 #include "tachyon/zk/lookup/halo2/scheme.h"
+#include "tachyon/zk/lookup/logup/scheme.h"
 #include "tachyon/zk/plonk/examples/fibonacci/fibonacci1_circuit.h"
 #include "tachyon/zk/plonk/examples/fibonacci/fibonacci2_circuit.h"
 #include "tachyon/zk/plonk/examples/fibonacci/fibonacci3_circuit.h"
@@ -25,6 +26,10 @@ using BN254Halo2LS = lookup::halo2::Scheme<typename BN254SHPlonk::Poly,
                                            typename BN254SHPlonk::Evals,
                                            typename BN254SHPlonk::Commitment>;
 
+using BN254LogUpLS = lookup::logup::Scheme<typename BN254SHPlonk::Poly,
+                                           typename BN254SHPlonk::Evals,
+                                           typename BN254SHPlonk::Commitment>;
+
 template <typename Circuit>
 constexpr bool IsSimpleFloorPlanner =
     std::is_same_v<typename Circuit::FloorPlanner, SimpleFloorPlanner<Circuit>>;