feat(math): impl remove zeros for sparse univariate poly #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batzor
force-pushed
the
feat(math)/remove-zeros-for-sparse-poly
branch
from
9a9b1af
to
155f934
Compare
batzor
force-pushed
the
feat(math)/remove-zeros-for-sparse-poly
branch
from
155f934
to
78fd8bd
Compare
batzor
force-pushed
the
feat(math)/remove-zeros-for-sparse-poly
branch
from
29ebb3c
to
23f5160
Compare
chokobole
reviewed
Jun 7, 2024
batzor
force-pushed
the
feat(math)/remove-zeros-for-sparse-poly
branch
from
23f5160
to
742336a
Compare
TomTaehoonKim
requested changes
Jun 7, 2024
tachyon/math/polynomials/univariate/univariate_sparse_polynomial_unittest.cc
Outdated
Show resolved
Hide resolved
batzor
force-pushed
the
feat(math)/remove-zeros-for-sparse-poly
branch
2 times, most recently
from
ae88fb4
to
9d78494
Compare
ashjeong
requested changes
Jun 10, 2024
tachyon/math/polynomials/univariate/univariate_dense_coefficients.h
Outdated
Show resolved
Hide resolved
batzor
force-pushed
the
feat(math)/remove-zeros-for-sparse-poly
branch
from
9d78494
to
4394f2c
Compare
TomTaehoonKim
requested changes
Jun 10, 2024
tachyon/math/polynomials/univariate/univariate_sparse_polynomial_unittest.cc
Outdated
Show resolved
Hide resolved
|
@batzor For the second commit, I can agree for the sparse coefficients but not with the dense coefficients. What's the motivation behind reducing the usage of remove high degree zeros for dense coefficients? |
|
@TomTaehoonKim Indeed, the |
batzor
force-pushed
the
feat(math)/remove-zeros-for-sparse-poly
branch
2 times, most recently
from
250246b
to
6561174
Compare
Zero cannot be in c_terms if the input polynomials are clean
batzor
force-pushed
the
feat(math)/remove-zeros-for-sparse-poly
branch
from
6561174
to
65131d2
Compare
|
@chokobole I reordered the commits as you requested. Hope its more clear now;; |
chokobole
reviewed
Jun 11, 2024
tachyon/math/polynomials/univariate/univariate_sparse_coefficients.h
Outdated
Show resolved
Hide resolved
batzor
force-pushed
the
feat(math)/remove-zeros-for-sparse-poly
branch
from
65131d2
to
802ef70
Compare
Insun35
added a commit
that referenced
this pull request
Jun 13, 2024
Insun35
added a commit
that referenced
this pull request
Jun 13, 2024
Insun35
added a commit
that referenced
this pull request
Jun 13, 2024
Insun35
added a commit
that referenced
this pull request
Jun 13, 2024
chokobole
pushed a commit
that referenced
this pull request
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RemoveHighDegreeZeros()toRemoveZeros()in univariate spare polynomial